[demangler] Node precision dumper

[urnathan]

Summary

Another fix from fixing up D120905

The empty print(Prec) functions added in fixing that breakage need bodies. This is that.

[dblaikie]

can/should this have test coverage?

[urnathan]

In D122740#3424667, @dblaikie wrote:

can/should this have test coverage?

Doesn't look simple. This is inside NDEBUG and explicitly writes to stderr, so I'm not sure how to capture that?

[dblaikie]

In D122740#3430230, @urnathan wrote:

In D122740#3424667, @dblaikie wrote:

can/should this have test coverage?

Doesn't look simple. This is inside NDEBUG and explicitly writes to stderr, so I'm not sure how to capture that?

Ah, I actually just was glancing at a commit that tested a situation like this ( rG9a62d9db2e1f6064e6c20344870f5e9d43a8de43 ) - so it can be/is done by REQUIRES: asserts on a lit test and then checking stderr (possibly/usually by 2>&1 to just collapse stderr and stdout together).

I'd expect/hope there is already other test coverage for this general feature that you could extend - or is this whole printing system untested?

[urnathan]

In D122740#3433877, @dblaikie wrote:

In D122740#3430230, @urnathan wrote:

In D122740#3424667, @dblaikie wrote:

can/should this have test coverage?

Doesn't look simple. This is inside NDEBUG and explicitly writes to stderr, so I'm not sure how to capture that?

Ah, I actually just was glancing at a commit that tested a situation like this ( rG9a62d9db2e1f6064e6c20344870f5e9d43a8de43 ) - so it can be/is done by REQUIRES: asserts on a lit test and then checking stderr (possibly/usually by 2>&1 to just collapse stderr and stdout together).

I'd expect/hope there is already other test coverage for this general feature that you could extend - or is this whole printing system untested?

I cannot see existing tests for this. AFAICT the node dumping machinery is accessible via debugging llvm. So I don't really see how a unittest could test it, nor how one could invoke the compiler to get at it.

The only 3 dump member tests I can find in llvm/unittest/...

IR/DominatorTreeBatchUpdatesTest.cpp:
Target/AMDGPU/ExecMayBeModifiedBeforeAnyUse.cpp:
Transforms/Vectorize/VPlanTest.cpp:

but they only seem to be checking the dumpers don't crash.

[dblaikie]

Ah, these aren't invoked from any user-accessible codepath (even in an asserts build), fair enough. Thanks!

libcxxabi/src/cxa_demangle.cpp

void print(TemplateParamKind TPK) {
     case TemplateParamKind::Type:
       return printStr("TemplateParamKind::Type");
     case TemplateParamKind::NonType:
       return printStr("TemplateParamKind::NonType");
     case TemplateParamKind::Template:
       return printStr("TemplateParamKind::Template");
     }
   }
-  void print(Node::Prec) {
-    // FIXME: Print Prec enumerator
+  void print(Node::Prec P) {
+    switch (P) {
+    case Node::Prec::Primary:
+      return printStr("Node::Prec::Primary");
+    case Node::Prec::Postfix:
+      return printStr("Node::Prec::Postfix");
+    case Node::Prec::Unary:
+      return printStr("Node::Prec::Unary");
+    case Node::Prec::Cast:
+      return printStr("Node::Prec::Cast");
+    case Node::Prec::PtrMem:
+      return printStr("Node::Prec::PtrMem");
+    case Node::Prec::Multiplicative:
+      return printStr("Node::Prec::Multiplicative");
+    case Node::Prec::Additive:
+      return printStr("Node::Prec::Additive");
+    case Node::Prec::Shift:
+      return printStr("Node::Prec::Shift");
+    case Node::Prec::Spaceship:
+      return printStr("Node::Prec::Spaceship");
+    case Node::Prec::Relational:
+      return printStr("Node::Prec::Relational");
+    case Node::Prec::Equality:
+      return printStr("Node::Prec::Equality");
+    case Node::Prec::And:
+      return printStr("Node::Prec::And");
+    case Node::Prec::Xor:
+      return printStr("Node::Prec::Xor");
+    case Node::Prec::Ior:
+      return printStr("Node::Prec::Ior");
+    case Node::Prec::AndIf:
+      return printStr("Node::Prec::AndIf");
+    case Node::Prec::OrIf:
+      return printStr("Node::Prec::OrIf");
+    case Node::Prec::Conditional:
+      return printStr("Node::Prec::Conditional");
+    case Node::Prec::Assign:
+      return printStr("Node::Prec::Assign");
+    case Node::Prec::Comma:
+      return printStr("Node::Prec::Comma");
+    case Node::Prec::Default:
+      return printStr("Node::Prec::Default");
+    }
   }
 
   void newLine() {
     printStr("\n");
     for (unsigned I = 0; I != Depth; ++I)
       printStr(" ");
     PendingNewline = false;
   }

llvm/lib/Demangle/ItaniumDemangle.cpp

void print(TemplateParamKind TPK) {
     case TemplateParamKind::Type:
       return printStr("TemplateParamKind::Type");
     case TemplateParamKind::NonType:
       return printStr("TemplateParamKind::NonType");
     case TemplateParamKind::Template:
       return printStr("TemplateParamKind::Template");
     }
   }
-  void print(llvm::itanium_demangle::Node::Prec) {
-    // Do nothing, the printing functions handle precedence with parentheses
-    // already.
+  void print(Node::Prec P) {
+    switch (P) {
+    case Node::Prec::Primary:
+      return printStr("Node::Prec::Primary");
+    case Node::Prec::Postfix:
+      return printStr("Node::Prec::Postfix");
+    case Node::Prec::Unary:
+      return printStr("Node::Prec::Unary");
+    case Node::Prec::Cast:
+      return printStr("Node::Prec::Cast");
+    case Node::Prec::PtrMem:
+      return printStr("Node::Prec::PtrMem");
+    case Node::Prec::Multiplicative:
+      return printStr("Node::Prec::Multiplicative");
+    case Node::Prec::Additive:
+      return printStr("Node::Prec::Additive");
+    case Node::Prec::Shift:
+      return printStr("Node::Prec::Shift");
+    case Node::Prec::Spaceship:
+      return printStr("Node::Prec::Spaceship");
+    case Node::Prec::Relational:
+      return printStr("Node::Prec::Relational");
+    case Node::Prec::Equality:
+      return printStr("Node::Prec::Equality");
+    case Node::Prec::And:
+      return printStr("Node::Prec::And");
+    case Node::Prec::Xor:
+      return printStr("Node::Prec::Xor");
+    case Node::Prec::Ior:
+      return printStr("Node::Prec::Ior");
+    case Node::Prec::AndIf:
+      return printStr("Node::Prec::AndIf");
+    case Node::Prec::OrIf:
+      return printStr("Node::Prec::OrIf");
+    case Node::Prec::Conditional:
+      return printStr("Node::Prec::Conditional");
+    case Node::Prec::Assign:
+      return printStr("Node::Prec::Assign");
+    case Node::Prec::Comma:
+      return printStr("Node::Prec::Comma");
+    case Node::Prec::Default:
+      return printStr("Node::Prec::Default");
+    }
   }
 
   void newLine() {
     printStr("\n");
     for (unsigned I = 0; I != Depth; ++I)
       printStr(" ");
     PendingNewline = false;
   }