This is an archive of the discontinued LLVM Phabricator instance.

Differential D122333

[mlir][MemRef] Fix warning on unsigned comparison
ClosedPublic

Authored by NathanielMcVicar on Mar 23 2022, 10:48 AM.

Details

Reviewers
mravishankar
gysit
stella.stamenova
mehdi_amini
Commits
rG4907cfe2cb67: [mlir][MemRef] Fix warning on unsigned comparison
Summary

Fix warning in clang introduced in D121766.

Diff Detail

Event Timeline

NathanielMcVicar created this revision.Mar 23 2022, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 10:48 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 19 others. · View Herald Transcript
NathanielMcVicar requested review of this revision.Mar 23 2022, 10:48 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 23 2022, 10:48 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
NathanielMcVicar edited the summary of this revision. (Show Details)Mar 23 2022, 11:00 AM
NathanielMcVicar added reviewers: mravishankar, gysit, stella.stamenova.
Harbormaster completed remote builds in B155911: Diff 417689.Mar 23 2022, 11:11 AM
mehdi_amini accepted this revision.Mar 23 2022, 12:28 PM
This revision is now accepted and ready to land.Mar 23 2022, 12:28 PM
Closed by commit rG4907cfe2cb67: [mlir][MemRef] Fix warning on unsigned comparison (authored by NathanielMcVicar, committed by stella.stamenova). · Explain WhyMar 23 2022, 12:55 PM
This revision was automatically updated to reflect the committed changes.
stella.stamenova added a commit: rG4907cfe2cb67: [mlir][MemRef] Fix warning on unsigned comparison.

Revision Contents

PathSize
mlir/
lib/
Dialect/
MemRef/
IR/
3 lines

Diff 417723

mlir/lib/Dialect/MemRef/IR/MemRefOps.cpp

Show First 20 Lines • Show All 755 Lines • ▼ Show 20 LinescomputeMemRefRankReductionMask(MemRefType originalType, MemRefType reducedType,
for (const auto &dim : llvm::enumerate(sizes)) for (const auto &dim : llvm::enumerate(sizes))
if (auto attr = dim.value().dyn_cast<Attribute>()) if (auto attr = dim.value().dyn_cast<Attribute>())
if (attr.cast<IntegerAttr>().getInt() == 1) if (attr.cast<IntegerAttr>().getInt() == 1)
unusedDims.set(dim.index()); unusedDims.set(dim.index());
// Early exit for the case where the number of unused dims matches the number // Early exit for the case where the number of unused dims matches the number
// of ranks reduced. // of ranks reduced.
if (unusedDims.count() + reducedType.getRank() == originalType.getRank()) if (static_cast<int64_t>(unusedDims.count()) + reducedType.getRank() ==
originalType.getRank())
return unusedDims; return unusedDims;
SmallVector<int64_t> originalStrides, candidateStrides; SmallVector<int64_t> originalStrides, candidateStrides;
int64_t originalOffset, candidateOffset; int64_t originalOffset, candidateOffset;
if (failed( if (failed(
getStridesAndOffset(originalType, originalStrides, originalOffset)) || getStridesAndOffset(originalType, originalStrides, originalOffset)) ||
failed( failed(
getStridesAndOffset(reducedType, candidateStrides, candidateOffset))) getStridesAndOffset(reducedType, candidateStrides, candidateOffset)))
▲ Show 20 Lines • Show All 1,873 Lines • Show Last 20 Lines