diff --git a/clang/lib/Driver/ToolChains/Gnu.cpp b/clang/lib/Driver/ToolChains/Gnu.cpp --- a/clang/lib/Driver/ToolChains/Gnu.cpp +++ b/clang/lib/Driver/ToolChains/Gnu.cpp @@ -382,6 +382,29 @@ Exec, CmdArgs, Inputs, Output)); } +static void addFortranRuntimeLibraryPath(const ToolChain &TC, + const ArgList &Args, + ArgStringList &CmdArgs) { + // Default to the /../lib directory. This works fine on the + // platforms that we have tested so far. We will probably have to re-fine + // this in the future. In particular: + // * on some platforms, we may need to use lib64 instead of lib (you can use + // CLANG_LIBDIR_SUFFIX to automate this) + // * this logic should also work on other similar platforms too, so we + // should move it to one of Gnu's parent tool{chain} classes + SmallString<256> DefaultLibPath = + llvm::sys::path::parent_path(TC.getDriver().Dir); + llvm::sys::path::append(DefaultLibPath, Twine("lib")); + CmdArgs.push_back(Args.MakeArgString("-L" + DefaultLibPath)); +} + +static void addFortranLinkerFlags(ArgStringList &CmdArgs) { + CmdArgs.push_back("-lFortran_main"); + CmdArgs.push_back("-lFortranRuntime"); + CmdArgs.push_back("-lFortranDecimal"); + CmdArgs.push_back("-lm"); +} + void tools::gnutools::Linker::ConstructJob(Compilation &C, const JobAction &JA, const InputInfo &Output, const InputInfoList &Inputs, @@ -668,6 +691,12 @@ } } + // Additional linker set-up and flags for Fortran + if (D.IsFlangMode() ) { + addFortranRuntimeLibraryPath(ToolChain, Args, CmdArgs); + addFortranLinkerFlags(CmdArgs); + } + Args.AddAllArgs(CmdArgs, options::OPT_T); const char *Exec = Args.MakeArgString(ToolChain.GetLinkerPath()); diff --git a/flang/include/flang/Runtime/stop.h b/flang/include/flang/Runtime/stop.h --- a/flang/include/flang/Runtime/stop.h +++ b/flang/include/flang/Runtime/stop.h @@ -27,7 +27,7 @@ NORETURN void RTNAME(ProgramEndStatement)(NO_ARGUMENTS); // Extensions -NORETURN void RTNAME(Exit)(int status = EXIT_SUCCESS); +NORETURN void RTNAME(Exit)(int status DEFAULT_VALUE(EXIT_SUCCESS)); NORETURN void RTNAME(Abort)(NO_ARGUMENTS); // Crash with an error message when the program dynamically violates a Fortran diff --git a/flang/runtime/CMakeLists.txt b/flang/runtime/CMakeLists.txt --- a/flang/runtime/CMakeLists.txt +++ b/flang/runtime/CMakeLists.txt @@ -30,6 +30,8 @@ # with different names include_directories(AFTER ${CMAKE_CURRENT_BINARY_DIR}) +add_subdirectory(FortranMain) + add_flang_library(FortranRuntime ISO_Fortran_binding.cpp allocatable.cpp diff --git a/flang/runtime/FortranMain/CMakeLists.txt b/flang/runtime/FortranMain/CMakeLists.txt new file mode 100644 --- /dev/null +++ b/flang/runtime/FortranMain/CMakeLists.txt @@ -0,0 +1,3 @@ +llvm_add_library(Fortran_main STATIC + Fortran_main.c +) diff --git a/flang/runtime/FortranMain/Fortran_main.c b/flang/runtime/FortranMain/Fortran_main.c new file mode 100644 --- /dev/null +++ b/flang/runtime/FortranMain/Fortran_main.c @@ -0,0 +1,21 @@ +//===-- runtime/FortranMain/Fortran_main.c --------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "flang/Runtime/main.h" +#include "flang/Runtime/stop.h" + +/* main entry into PROGRAM */ +void _QQmain(); + +/* C main stub */ +int main(int argc, const char *argv[], const char *envp[]) { + RTNAME(ProgramStart)(argc, argv, envp); + _QQmain(); + RTNAME(ProgramEndStatement)(); + return 0; +} diff --git a/flang/test/CMakeLists.txt b/flang/test/CMakeLists.txt --- a/flang/test/CMakeLists.txt +++ b/flang/test/CMakeLists.txt @@ -57,6 +57,9 @@ bbc llvm-objdump split-file + FortranRuntime + Fortran_main + FortranDecimal ) if (FLANG_INCLUDE_TESTS) diff --git a/flang/test/Driver/linker-flags.f90 b/flang/test/Driver/linker-flags.f90 new file mode 100644 --- /dev/null +++ b/flang/test/Driver/linker-flags.f90 @@ -0,0 +1,30 @@ +! Verify that the Fortran runtime libraries are present in the linker +! invocation. These libraries are added on top of other standard runtime +! libraries that the Clang driver will include. + +! NOTE: The additional linker flags tested here are currently specified in +! clang/lib/Driver/Toolchains/Gnu.cpp. This makes the current implementation GNU +! (Linux) specific. The following line will make sure that this test is skipped +! on Windows. Ideally we should find a more robust way of testing this. +! REQUIRES: shell +! UNSUPPORTED: darwin, macos + +!------------ +! RUN COMMAND +!------------ +! RUN: %flang -### --ld-path=/usr/bin/ld %S/Inputs/hello.f90 2>&1 | FileCheck %s + +!---------------- +! EXPECTED OUTPUT +!---------------- +! Compiler invocation to generate the object file +! CHECK-LABEL: {{.*}} "-emit-obj" +! CHECK-SAME: "-o" "[[object_file:.*]]" {{.*}}Inputs/hello.f90 + +! Linker invocation to generate the executable +! CHECK-LABEL: "/usr/bin/ld" +! CHECK-SAME: "[[object_file]]" +! CHECK-SAME: -lFortran_main +! CHECK-SAME: -lFortranRuntime +! CHECK-SAME: -lFortranDecimal +! CHECK-SAME: -lm