diff --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp --- a/llvm/lib/IR/Verifier.cpp +++ b/llvm/lib/IR/Verifier.cpp @@ -1731,12 +1731,23 @@ verifyAttributeTypes(Attrs, V); - for (Attribute Attr : Attrs) + for (Attribute Attr : Attrs) { Assert(Attr.isStringAttribute() || Attribute::canUseAsParamAttr(Attr.getKindAsEnum()), "Attribute '" + Attr.getAsString() + "' does not apply to parameters", V); + if (Attr.getKindAsEnum() == Attribute::Alignment) { + Align AttrAlign = Attr.getAlignment().valueOrOne(); + // ArgFlagsTy::MemAlign only have 4 bits for alignment, so the + // alignment size should not exceed 1 << 14, otherwise it can NOT + // be properly lowered. + Align MaxAlign(1 << 15); + Assert(AttrAlign < MaxAlign, + "Attribute '" + Attr.getAsString() + "' exceed the max size 2^14", + V); + } + } if (Attrs.hasAttribute(Attribute::ImmArg)) { Assert(Attrs.getNumAttributes() == 1, @@ -3142,6 +3153,24 @@ Assert(verifyAttributeCount(Attrs, Call.arg_size()), "Attribute after last parameter!", Call); + auto VerifyTypeAlign = [&](Type *Ty, const Twine &Message) { + if (!Ty->isSized()) + return; + Align ABIAlign = DL.getABITypeAlign(Ty); + // ArgFlagsTy::MemAlign only have 4 bits for alignment, so the + // alignment size should not exceed 1 << 14, otherwise it can NOT + // be properly lowered. + Align MaxAlign(1 << 15); + Assert(ABIAlign < MaxAlign, + "Incorrect alignment of " + Message + " to called function!", Call); + }; + + VerifyTypeAlign(FTy->getReturnType(), "return type"); + for (unsigned i = 0, e = FTy->getNumParams(); i != e; ++i) { + Type *Ty = FTy->getParamType(i); + VerifyTypeAlign(Ty, "argument passed"); + } + Function *Callee = dyn_cast(Call.getCalledOperand()->stripPointerCasts()); bool IsIntrinsic = Callee && Callee->isIntrinsic(); diff --git a/llvm/test/Verifier/param-align.ll b/llvm/test/Verifier/param-align.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Verifier/param-align.ll @@ -0,0 +1,10 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +; CHECK: Incorrect alignment of argument passed to called function! +define dso_local void @foo(<8192 x float> noundef %vec) { +entry: + call void @bar(<8192 x float> %vec) + ret void +} + +declare dso_local void @bar(<8192 x float>) diff --git a/llvm/test/Verifier/param-attr-align.ll b/llvm/test/Verifier/param-attr-align.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Verifier/param-attr-align.ll @@ -0,0 +1,11 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +; CHECK: Attribute 'align 32768' exceed the max size 2^14 +define dso_local void @foo(i8* %p) { +entry: + %p1 = bitcast i8* %p to <8 x float>* + call void @bar(<8 x float>* noundef byval(<8 x float>) align 32768 %p1) + ret void +} + +declare dso_local void @bar(<8 x float>* %p) diff --git a/llvm/test/Verifier/param-ret-align.ll b/llvm/test/Verifier/param-ret-align.ll new file mode 100644 --- /dev/null +++ b/llvm/test/Verifier/param-ret-align.ll @@ -0,0 +1,10 @@ +; RUN: not llvm-as < %s 2>&1 | FileCheck %s + +; CHECK: Incorrect alignment of return type to called function! +define dso_local void @foo() { +entry: + call <8192 x float> @bar() + ret void +} + +declare dso_local <8192 x float> @bar()