diff --git a/flang/include/flang/Optimizer/Transforms/Passes.h b/flang/include/flang/Optimizer/Transforms/Passes.h --- a/flang/include/flang/Optimizer/Transforms/Passes.h +++ b/flang/include/flang/Optimizer/Transforms/Passes.h @@ -37,6 +37,7 @@ std::unique_ptr createMemoryAllocationPass(); std::unique_ptr createMemoryAllocationPass(bool dynOnHeap, std::size_t maxStackSize); +std::unique_ptr createAnnotateConstantOperandsPass(); // declarative passes #define GEN_PASS_REGISTRATION diff --git a/flang/include/flang/Optimizer/Transforms/Passes.td b/flang/include/flang/Optimizer/Transforms/Passes.td --- a/flang/include/flang/Optimizer/Transforms/Passes.td +++ b/flang/include/flang/Optimizer/Transforms/Passes.td @@ -74,6 +74,23 @@ ]; } +def AnnotateConstantOperands : Pass<"annotate-constant"> { + let summary = "Annotate constant operands to all FIR operations"; + let description = [{ + The MLIR canonicalizer makes a distinction between constants based on how + they are packaged in the IR. A constant value is wrapped in an Attr and that + Attr can be attached to an Op. There is a distinguished Op, ConstantOp, that + merely has one of these Attr attached. + + The MLIR canonicalizer treats constants referenced by an Op and constants + referenced through a ConstantOp as having distinct semantics. This pass + eliminates that distinction, so hashconsing of Ops, basic blocks, etc. + behaves as one would expect. + }]; + let constructor = "::fir::createAnnotateConstantOperandsPass()"; + let dependentDialects = [ "fir::FIROpsDialect" ]; +} + def ArrayValueCopy : Pass<"array-value-copy", "::mlir::FuncOp"> { let summary = "Convert array value operations to memory operations."; let description = [{ @@ -91,6 +108,7 @@ This pass is required before code gen to the LLVM IR dialect. }]; let constructor = "::fir::createArrayValueCopyPass()"; + let dependentDialects = [ "fir::FIROpsDialect" ]; } def CharacterConversion : Pass<"character-conversion"> { diff --git a/flang/lib/Optimizer/Transforms/AnnotateConstant.cpp b/flang/lib/Optimizer/Transforms/AnnotateConstant.cpp new file mode 100644 --- /dev/null +++ b/flang/lib/Optimizer/Transforms/AnnotateConstant.cpp @@ -0,0 +1,55 @@ +//===-- AnnotateConstant.cpp ----------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "PassDetail.h" +#include "flang/Optimizer/Dialect/FIROps.h" +#include "flang/Optimizer/Transforms/Passes.h" +#include "mlir/IR/BuiltinAttributes.h" + +#define DEBUG_TYPE "flang-annotate-constant" + +using namespace fir; + +namespace { +struct AnnotateConstantOperands + : AnnotateConstantOperandsBase { + void runOnOperation() override { + auto *context = &getContext(); + mlir::Dialect *firDialect = context->getLoadedDialect("fir"); + getOperation()->walk([&](mlir::Operation *op) { + // We filter out other dialects even though they may undergo merging of + // non-equal constant values by the canonicalizer as well. + if (op->getDialect() == firDialect) { + llvm::SmallVector attrs; + bool hasOneOrMoreConstOpnd = false; + for (mlir::Value opnd : op->getOperands()) { + if (auto constOp = mlir::dyn_cast_or_null( + opnd.getDefiningOp())) { + attrs.push_back(constOp.getValue()); + hasOneOrMoreConstOpnd = true; + } else if (auto addrOp = mlir::dyn_cast_or_null( + opnd.getDefiningOp())) { + attrs.push_back(addrOp.getSymbol()); + hasOneOrMoreConstOpnd = true; + } else { + attrs.push_back(mlir::UnitAttr::get(context)); + } + } + if (hasOneOrMoreConstOpnd) + op->setAttr("canonicalize_constant_operands", + mlir::ArrayAttr::get(context, attrs)); + } + }); + } +}; + +} // namespace + +std::unique_ptr fir::createAnnotateConstantOperandsPass() { + return std::make_unique(); +} diff --git a/flang/lib/Optimizer/Transforms/CMakeLists.txt b/flang/lib/Optimizer/Transforms/CMakeLists.txt --- a/flang/lib/Optimizer/Transforms/CMakeLists.txt +++ b/flang/lib/Optimizer/Transforms/CMakeLists.txt @@ -2,6 +2,7 @@ AbstractResult.cpp AffinePromotion.cpp AffineDemotion.cpp + AnnotateConstant.cpp CharacterConversion.cpp ArrayValueCopy.cpp ExternalNameConversion.cpp diff --git a/flang/test/Fir/annotate-constant.fir b/flang/test/Fir/annotate-constant.fir new file mode 100644 --- /dev/null +++ b/flang/test/Fir/annotate-constant.fir @@ -0,0 +1,9 @@ +// RUN: fir-opt -annotate-constant %s | FileCheck %s + +// CHECK-LABEL: func @annotate_test() -> !fir.ref> { +func @annotate_test() -> !fir.ref> { + %1 = arith.constant 5 : index + // CHECK: %[[a:.*]] = fir.alloca !fir.array, %{{.*}} {canonicalize_constant_operands = [5 : index]} + %2 = fir.alloca !fir.array, %1 + return %2 : !fir.ref> +}