Index: lib/CodeGen/SelectionDAG/DAGCombiner.cpp =================================================================== --- lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -312,6 +312,7 @@ SDValue visitMGATHER(SDNode *N); SDValue visitMSCATTER(SDNode *N); SDValue visitFP_TO_FP16(SDNode *N); + SDValue visitFP16_TO_FP(SDNode *N); SDValue visitFADDForFMACombine(SDNode *N); SDValue visitFSUBForFMACombine(SDNode *N); @@ -1406,6 +1407,7 @@ case ISD::MSCATTER: return visitMSCATTER(N); case ISD::MSTORE: return visitMSTORE(N); case ISD::FP_TO_FP16: return visitFP_TO_FP16(N); + case ISD::FP16_TO_FP: return visitFP16_TO_FP(N); } return SDValue(); } @@ -12977,6 +12979,21 @@ return SDValue(); } +SDValue DAGCombiner::visitFP16_TO_FP(SDNode *N) { + SDValue N0 = N->getOperand(0); + + // fold fp16_to_fp(op & 0xffff) -> fp16_to_fp(op) + if (N0->getOpcode() == ISD::AND) { + ConstantSDNode *AndConst = getAsNonOpaqueConstant(N0.getOperand(1)); + if (AndConst && AndConst->getAPIntValue() == 0xffff) { + return DAG.getNode(ISD::FP16_TO_FP, SDLoc(N), N->getValueType(0), + N0.getOperand(0)); + } + } + + return SDValue(); +} + /// Returns a vector_shuffle if it able to transform an AND to a vector_shuffle /// with the destination vector and a zero vector. /// e.g. AND V, <0xffffffff, 0, 0xffffffff, 0>. ==> Index: test/CodeGen/ARM/fp16-args.ll =================================================================== --- /dev/null +++ test/CodeGen/ARM/fp16-args.ll @@ -0,0 +1,40 @@ +; RUN: llc -float-abi soft -mattr=+fp16 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=SOFT +; RUN: llc -float-abi hard -mattr=+fp16 < %s | FileCheck %s --check-prefix=CHECK --check-prefix=HARD + +target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64" +target triple = "armv7a--none-eabi" + +define float @foo(float %a.coerce, float %b.coerce) { +entry: + %0 = bitcast float %a.coerce to i32 + %tmp.0.extract.trunc = trunc i32 %0 to i16 + %1 = bitcast i16 %tmp.0.extract.trunc to half + %2 = bitcast float %b.coerce to i32 + %tmp1.0.extract.trunc = trunc i32 %2 to i16 + %3 = bitcast i16 %tmp1.0.extract.trunc to half + %4 = fadd half %1, %3 + %5 = bitcast half %4 to i16 + %tmp5.0.insert.ext = zext i16 %5 to i32 + %6 = bitcast i32 %tmp5.0.insert.ext to float + ret float %6 +; CHECK: foo: + +; SOFT: vmov {{s[0-9]+}}, r1 +; SOFT: vmov {{s[0-9]+}}, r0 +; SOFT: vcvtb.f32.f16 {{s[0-9]+}}, {{s[0-9]+}} +; SOFT: vcvtb.f32.f16 {{s[0-9]+}}, {{s[0-9]+}} +; SOFT: vadd.f32 {{s[0-9]+}}, {{s[0-9]+}}, {{s[0-9]+}} +; SOFT: vcvtb.f16.f32 {{s[0-9]+}}, {{s[0-9]+}} +; SOFT: vmov r0, {{s[0-9]+}} + +; HARD-NOT: vmov +; HARD-NOT: uxth +; HARD: vcvtb.f32.f16 {{s[0-9]+}}, s1 +; HARD: vcvtb.f32.f16 {{s[0-9]+}}, s0 +; HARD: vadd.f32 {{s[0-9]+}}, {{s[0-9]+}}, {{s[0-9]+}} +; HARD: vcvtb.f16.f32 s0, {{s[0-9]+}} +; HARD-NOT: vmov +; HARD-NOT: uxth + +; CHECK: bx lr +}