diff --git a/clang/lib/Analysis/CFG.cpp b/clang/lib/Analysis/CFG.cpp --- a/clang/lib/Analysis/CFG.cpp +++ b/clang/lib/Analysis/CFG.cpp @@ -1891,7 +1891,7 @@ // (which is different from the current class) is responsible for // destroying them. const CXXRecordDecl *CD = VI.getType()->getAsCXXRecordDecl(); - if (!CD->hasTrivialDestructor()) { + if (CD && !CD->hasTrivialDestructor()) { autoCreateBlock(); appendBaseDtor(Block, &VI); } @@ -1901,7 +1901,7 @@ for (const auto &BI : RD->bases()) { if (!BI.isVirtual()) { const CXXRecordDecl *CD = BI.getType()->getAsCXXRecordDecl(); - if (!CD->hasTrivialDestructor()) { + if (CD && !CD->hasTrivialDestructor()) { autoCreateBlock(); appendBaseDtor(Block, &BI); } diff --git a/clang/unittests/Analysis/CFGBuildResult.h b/clang/unittests/Analysis/CFGBuildResult.h --- a/clang/unittests/Analysis/CFGBuildResult.h +++ b/clang/unittests/Analysis/CFGBuildResult.h @@ -56,13 +56,15 @@ TheBuildResult = BuildResult::SawFunctionBody; Options.AddImplicitDtors = true; if (std::unique_ptr Cfg = - CFG::buildCFG(nullptr, Body, Result.Context, Options)) + CFG::buildCFG(Func, Body, Result.Context, Options)) TheBuildResult = {BuildResult::BuiltCFG, Func, std::move(Cfg), std::move(AST)}; } }; -inline BuildResult BuildCFG(const char *Code, CFG::BuildOptions Options = {}) { +template +BuildResult BuildCFG(const char *Code, CFG::BuildOptions Options = {}, + FuncMatcherT FuncMatcher = ast_matchers::anything()) { std::vector Args = {"-std=c++11", "-fno-delayed-template-parsing"}; std::unique_ptr AST = tooling::buildASTFromCodeWithArgs(Code, Args); @@ -72,7 +74,8 @@ CFGCallback Callback(std::move(AST)); Callback.Options = Options; ast_matchers::MatchFinder Finder; - Finder.addMatcher(ast_matchers::functionDecl().bind("func"), &Callback); + Finder.addMatcher(ast_matchers::functionDecl(FuncMatcher).bind("func"), + &Callback); Finder.matchAST(Callback.AST->getASTContext()); return std::move(Callback.TheBuildResult); diff --git a/clang/unittests/Analysis/CFGTest.cpp b/clang/unittests/Analysis/CFGTest.cpp --- a/clang/unittests/Analysis/CFGTest.cpp +++ b/clang/unittests/Analysis/CFGTest.cpp @@ -70,6 +70,27 @@ EXPECT_EQ(BuildResult::BuiltCFG, BuildCFG(Code).getStatus()); } +// Constructing a CFG with a dependent base should not crash. +TEST(CFG, DependantBaseAddImplicitDtors) { + const char *Code = R"( + template + struct Base { + virtual ~Base() {} + }; + + template + struct Derived : public Base { + virtual ~Derived() {} + }; + )"; + CFG::BuildOptions Options; + Options.AddImplicitDtors = true; + Options.setAllAlwaysAdd(); + EXPECT_EQ(BuildResult::BuiltCFG, + BuildCFG(Code, Options, ast_matchers::hasName("~Derived")) + .getStatus()); +} + TEST(CFG, IsLinear) { auto expectLinear = [](bool IsLinear, const char *Code) { BuildResult B = BuildCFG(Code);