Page MenuHomePhabricator

Make @skipUnlessArch actually skip instead of XFAIL
ClosedPublic

Authored by zturner on Aug 14 2015, 2:03 PM.

Details

Reviewers
chaoren

Diff Detail

Event Timeline

zturner updated this revision to Diff 32186.Aug 14 2015, 2:03 PM
zturner retitled this revision from to Make @skipUnlessArch actually skip instead of XFAIL.
zturner updated this object.
zturner added a reviewer: chaoren.
zturner added a subscriber: lldb-commits.
chaoren added inline comments.Aug 14 2015, 2:35 PM
test/lldbtest.py
943

Is there a reason

return unittest2.skipUnless(getArchitecture() in archlist, ...)

is not sufficient?

Also, please add a doc string, like the other skip{If,Unless} methods.

zturner added inline comments.Aug 14 2015, 2:51 PM
test/lldbtest.py
943

getArchitecture() is a member of self, which is not defined here. TBH this stuff is beyond my Python level, I tried simpler versions but this is how I ultimately got it working after seeing what some of the other decorators did.

chaoren accepted this revision.Aug 14 2015, 4:24 PM
chaoren edited edge metadata.
chaoren added inline comments.
test/lldbtest.py
943

Okay. I see what you mean. LGTM for now (if it works), I'll add a change later to unittest2.skip* to allow a callback that takes a test_item, instead of just a condition.

This revision is now accepted and ready to land.Aug 14 2015, 4:24 PM
chaoren closed this revision.Aug 20 2015, 12:16 PM