Index: llvm/lib/Analysis/InstructionSimplify.cpp =================================================================== --- llvm/lib/Analysis/InstructionSimplify.cpp +++ llvm/lib/Analysis/InstructionSimplify.cpp @@ -2533,6 +2533,19 @@ // So, we'll assume that two non-empty allocas have different addresses // for now. // + + auto isByValArg = [](const Value *V) { + const Argument *A = dyn_cast(V); + return A && A->hasByValAttr(); + }; + + // Byval args are backed by store which does not overlap with each other, + // allocas, or globals. + if (isByValArg(V1)) + return isa(V2) || isa(V2) || isByValArg(V2); + if (isByValArg(V2)) + return isa(V1) || isa(V1) || isByValArg(V1); + return isa(V1) && (isa(V2) || isa(V2)); } @@ -2638,7 +2651,7 @@ ObjectSizeOpts Opts; Opts.EvalMode = ObjectSizeOpts::Mode::Min; Opts.NullIsUnknownSize = - NullPointerIsDefined(cast(LHS)->getFunction()); + !CxtI || NullPointerIsDefined(CxtI->getFunction()); if (getObjectSize(LHS, LHSSize, DL, TLI, Opts) && getObjectSize(RHS, RHSSize, DL, TLI, Opts) && !LHSOffset.isNegative() && !RHSOffset.isNegative() && Index: llvm/test/Transforms/InstSimplify/compare.ll =================================================================== --- llvm/test/Transforms/InstSimplify/compare.ll +++ llvm/test/Transforms/InstSimplify/compare.ll @@ -2740,8 +2740,7 @@ ; TODO: Never equal define i1 @byval_args_inequal(i32* byval(i32) %a, i32* byval(i32) %b) { ; CHECK-LABEL: @byval_args_inequal( -; CHECK-NEXT: [[RES:%.*]] = icmp ne i32* [[A:%.*]], [[B:%.*]] -; CHECK-NEXT: ret i1 [[RES]] +; CHECK-NEXT: ret i1 true ; %res = icmp ne i32* %a, %b ret i1 %res @@ -2762,9 +2761,7 @@ ; TODO: Never equal define i1 @test_byval_alloca_inequal(i32* byval(i32) %a) { ; CHECK-LABEL: @test_byval_alloca_inequal( -; CHECK-NEXT: [[B:%.*]] = alloca i32, align 4 -; CHECK-NEXT: [[RES:%.*]] = icmp ne i32* [[A:%.*]], [[B]] -; CHECK-NEXT: ret i1 [[RES]] +; CHECK-NEXT: ret i1 true ; %b = alloca i32 %res = icmp ne i32* %a, %b