diff --git a/clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp b/clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp --- a/clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp +++ b/clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp @@ -19,14 +19,15 @@ static unsigned getNameSpecifierNestingLevel(const QualType &QType) { if (const ElaboratedType *ElType = QType->getAs()) { - const NestedNameSpecifier *NestedSpecifiers = ElType->getQualifier(); - unsigned NameSpecifierNestingLevel = 1; - do { - NameSpecifierNestingLevel++; - NestedSpecifiers = NestedSpecifiers->getPrefix(); - } while (NestedSpecifiers); - - return NameSpecifierNestingLevel; + if (const NestedNameSpecifier *NestedSpecifiers = ElType->getQualifier()) { + unsigned NameSpecifierNestingLevel = 1; + do { + NameSpecifierNestingLevel++; + NestedSpecifiers = NestedSpecifiers->getPrefix(); + } while (NestedSpecifiers); + + return NameSpecifierNestingLevel; + } } return 0; } @@ -68,6 +69,10 @@ PrintingPolicy PrintingPolicyWithSupressedTag(AstContext->getLangOpts()); PrintingPolicyWithSupressedTag.SuppressTagKeyword = true; PrintingPolicyWithSupressedTag.SuppressUnwrittenScope = true; + + PrintingPolicyWithSupressedTag.PrintCanonicalTypes = + !BaseExpr->getType()->isTypedefNameType(); + std::string BaseTypeName = BaseType.getAsString(PrintingPolicyWithSupressedTag); diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp --- a/clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp +++ b/clang-tools-extra/test/clang-tidy/checkers/readability-static-accessed-through-instance.cpp @@ -198,6 +198,28 @@ h<4>(); } +struct SP { + static int I; +} P; + +void usep() { + P.I; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member + // CHECK-FIXES: {{^}} SP::I;{{$}} +} + +namespace NSP { +struct SP { + static int I; +} P; +} // namespace NSP + +void usensp() { + NSP::P.I; + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: static member + // CHECK-FIXES: {{^}} NSP::SP::I;{{$}} +} + // Overloaded member access operator struct Q { static int K; @@ -237,9 +259,9 @@ namespace Outer { inline namespace Inline { - struct S { - static int I; - }; + struct S { + static int I; + }; } }