Page MenuHomePhabricator

Fetch SDK version from PlatformAndroid
ClosedPublic

Authored by tberghammer on Aug 11 2015, 4:32 AM.

Details

Summary

Fetch SDK version from PlatformAndroid

The SDK version implies the features supported by a given android
device. This version number will be used in future changes to execute
the right command on the device.

Diff Detail

Repository
rL LLVM

Event Timeline

tberghammer retitled this revision from to Fetch SDK version from PlatformAndroid.
tberghammer updated this object.
tberghammer added a reviewer: ovyalov.
tberghammer added a subscriber: lldb-commits.
ovyalov edited edge metadata.Aug 11 2015, 8:29 AM

Please see my comments.

source/Plugins/Platform/Android/PlatformAndroid.cpp
284 ↗(On Diff #31790)

Could you check for error that RunShellCommand returns?

290 ↗(On Diff #31790)

StringConvert::ToUInt32 ?

tberghammer edited edge metadata.

Address review comments

ovyalov accepted this revision.Aug 11 2015, 9:27 AM
ovyalov edited edge metadata.

Looks good.

source/Plugins/Platform/Android/PlatformAndroid.cpp
292 ↗(On Diff #31822)

Please add logging in case of error.

This revision is now accepted and ready to land.Aug 11 2015, 9:27 AM
This revision was automatically updated to reflect the committed changes.