diff --git a/clang/lib/CodeGen/CodeGenTypes.h b/clang/lib/CodeGen/CodeGenTypes.h --- a/clang/lib/CodeGen/CodeGenTypes.h +++ b/clang/lib/CodeGen/CodeGenTypes.h @@ -96,7 +96,7 @@ /// corresponding llvm::Type. llvm::DenseMap TypeCache; - llvm::SmallSet RecordsWithOpaqueMemberPointers; + llvm::DenseMap RecordsWithOpaqueMemberPointers; /// Helper for ConvertType. llvm::Type *ConvertFunctionTypeInternal(QualType FT); diff --git a/clang/lib/CodeGen/CodeGenTypes.cpp b/clang/lib/CodeGen/CodeGenTypes.cpp --- a/clang/lib/CodeGen/CodeGenTypes.cpp +++ b/clang/lib/CodeGen/CodeGenTypes.cpp @@ -29,16 +29,6 @@ using namespace clang; using namespace CodeGen; -#ifndef NDEBUG -#include "llvm/Support/CommandLine.h" -// TODO: turn on by default when defined(EXPENSIVE_CHECKS) once check-clang is -// -verify-type-cache clean. -static llvm::cl::opt VerifyTypeCache( - "verify-type-cache", - llvm::cl::desc("Verify that the type cache matches the computed type"), - llvm::cl::init(false), llvm::cl::Hidden); -#endif - CodeGenTypes::CodeGenTypes(CodeGenModule &cgm) : CGM(cgm), Context(cgm.getContext()), TheModule(cgm.getModule()), Target(cgm.getTarget()), TheCXXABI(cgm.getCXXABI()), @@ -437,14 +427,12 @@ TypeCache.find(Ty); if (TCI != TypeCache.end()) CachedType = TCI->second; - if (CachedType) { -#ifndef NDEBUG - if (!VerifyTypeCache) - return CachedType; -#else + // With expensive checks, check that the type we compute matches the + // cached type. +#ifndef EXPENSIVE_CHECKS + if (CachedType) return CachedType; #endif - } } // If we don't have it in the cache, convert it now. @@ -784,8 +772,14 @@ case Type::MemberPointer: { auto *MPTy = cast(Ty); if (!getCXXABI().isMemberPointerConvertible(MPTy)) { - RecordsWithOpaqueMemberPointers.insert(MPTy->getClass()); - ResultType = llvm::StructType::create(getLLVMContext()); + auto *C = MPTy->getClass(); + auto I = RecordsWithOpaqueMemberPointers.find(C); + if (I == RecordsWithOpaqueMemberPointers.end()) { + ResultType = llvm::StructType::create(getLLVMContext()); + RecordsWithOpaqueMemberPointers.insert({C, ResultType}); + } else { + ResultType = I->second; + } } else { ResultType = getCXXABI().ConvertMemberPointerType(MPTy); } @@ -822,13 +816,8 @@ } assert(ResultType && "Didn't convert a type?"); - -#ifndef NDEBUG - if (CachedType) { - assert(CachedType == ResultType && - "Cached type doesn't match computed type"); - } -#endif + assert((!CachedType || CachedType == ResultType) && + "Cached type doesn't match computed type"); if (ShouldUseCache) TypeCache[Ty] = ResultType; diff --git a/clang/test/CodeGenCXX/type-cache-2.cpp b/clang/test/CodeGenCXX/type-cache-2.cpp --- a/clang/test/CodeGenCXX/type-cache-2.cpp +++ b/clang/test/CodeGenCXX/type-cache-2.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -mllvm -verify-type-cache -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s +// RUN: %clang_cc1 -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s // REQUIRES: asserts, x86-registered-target // CHECK: call void @"?dc@z@@SAXU1@@Z" diff --git a/clang/test/CodeGenCXX/type-cache-3.cpp b/clang/test/CodeGenCXX/type-cache-3.cpp --- a/clang/test/CodeGenCXX/type-cache-3.cpp +++ b/clang/test/CodeGenCXX/type-cache-3.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -mllvm -verify-type-cache -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s +// RUN: %clang_cc1 -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s // REQUIRES: asserts, x86-registered-target // CHECK-LABEL: define {{.*}}@"?f@@YAXXZ"( diff --git a/clang/test/CodeGenCXX/type-cache.cpp b/clang/test/CodeGenCXX/type-cache.cpp --- a/clang/test/CodeGenCXX/type-cache.cpp +++ b/clang/test/CodeGenCXX/type-cache.cpp @@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -mllvm -verify-type-cache -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s +// RUN: %clang_cc1 -emit-llvm %s -o - -triple i386-pc-windows-msvc19.16.0 | FileCheck %s // REQUIRES: asserts, x86-registered-target // CHECK: call {}* @"?f@@YA?AUz@@XZ"()