diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.h b/llvm/lib/Target/RISCV/RISCVISelLowering.h --- a/llvm/lib/Target/RISCV/RISCVISelLowering.h +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.h @@ -75,6 +75,7 @@ // // FMV_H_X matches the semantics of the FMV.H.X. // FMV_X_ANYEXTH is similar to FMV.X.H but has an any-extended result. + // FMV_X_SIGNEXTH is similar to FMV.X.H and has a sign-extended result. // FMV_W_X_RV64 matches the semantics of the FMV.W.X. // FMV_X_ANYEXTW_RV64 is similar to FMV.X.W but has an any-extended result. // @@ -82,6 +83,7 @@ // unnecessary GPR->FPR->GPR moves. FMV_H_X, FMV_X_ANYEXTH, + FMV_X_SIGNEXTH, FMV_W_X_RV64, FMV_X_ANYEXTW_RV64, // FP to XLen int conversions. Corresponds to fcvt.l(u).s/d/h on RV64 and diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp --- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp @@ -1031,6 +1031,8 @@ setTargetDAGCombine(ISD::ROTL); setTargetDAGCombine(ISD::ROTR); setTargetDAGCombine(ISD::ANY_EXTEND); + if (Subtarget.hasStdExtZfh()) + setTargetDAGCombine(ISD::SIGN_EXTEND_INREG); if (Subtarget.hasStdExtF()) { setTargetDAGCombine(ISD::ZERO_EXTEND); setTargetDAGCombine(ISD::FP_TO_SINT); @@ -7518,6 +7520,18 @@ return combineSelectAndUseCommutative(N, DAG, /*AllOnes*/ false); } +static SDValue performSIGN_EXTEND_INREG(SDNode *N, SelectionDAG &DAG) { + SDValue Src = N->getOperand(0); + + // Fold (sext_inreg (fmv_x_anyexth X), i16) -> (fmv_x_signexth X) + if (Src.getOpcode() == RISCVISD::FMV_X_ANYEXTH && + cast(N->getOperand(1))->getVT().bitsGE(MVT::i16)) + return DAG.getNode(RISCVISD::FMV_X_SIGNEXTH, SDLoc(N), N->getValueType(0), + Src.getOperand(0)); + + return SDValue(); +} + // Attempt to turn ANY_EXTEND into SIGN_EXTEND if the input to the ANY_EXTEND // has users that require SIGN_EXTEND and the SIGN_EXTEND can be done for free // by an instruction like ADDW/SUBW/MULW. Without this the ANY_EXTEND would be @@ -8124,6 +8138,8 @@ return performORCombine(N, DAG, Subtarget); case ISD::XOR: return performXORCombine(N, DAG); + case ISD::SIGN_EXTEND_INREG: + return performSIGN_EXTEND_INREG(N, DAG); case ISD::ANY_EXTEND: return performANY_EXTENDCombine(N, DCI, Subtarget); case ISD::ZERO_EXTEND: @@ -10540,6 +10556,7 @@ NODE_NAME_CASE(FSR) NODE_NAME_CASE(FMV_H_X) NODE_NAME_CASE(FMV_X_ANYEXTH) + NODE_NAME_CASE(FMV_X_SIGNEXTH) NODE_NAME_CASE(FMV_W_X_RV64) NODE_NAME_CASE(FMV_X_ANYEXTW_RV64) NODE_NAME_CASE(FCVT_X) diff --git a/llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td b/llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td --- a/llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td +++ b/llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td @@ -17,13 +17,15 @@ def SDT_RISCVFMV_H_X : SDTypeProfile<1, 1, [SDTCisVT<0, f16>, SDTCisVT<1, XLenVT>]>; -def SDT_RISCVFMV_X_ANYEXTH +def SDT_RISCVFMV_X_EXTH : SDTypeProfile<1, 1, [SDTCisVT<0, XLenVT>, SDTCisVT<1, f16>]>; def riscv_fmv_h_x : SDNode<"RISCVISD::FMV_H_X", SDT_RISCVFMV_H_X>; def riscv_fmv_x_anyexth - : SDNode<"RISCVISD::FMV_X_ANYEXTH", SDT_RISCVFMV_X_ANYEXTH>; + : SDNode<"RISCVISD::FMV_X_ANYEXTH", SDT_RISCVFMV_X_EXTH>; +def riscv_fmv_x_signexth + : SDNode<"RISCVISD::FMV_X_SIGNEXTH", SDT_RISCVFMV_X_EXTH>; //===----------------------------------------------------------------------===// // Instructions @@ -299,6 +301,7 @@ // Moves (no conversion) def : Pat<(riscv_fmv_h_x GPR:$src), (FMV_H_X GPR:$src)>; def : Pat<(riscv_fmv_x_anyexth FPR16:$src), (FMV_X_H FPR16:$src)>; +def : Pat<(riscv_fmv_x_signexth FPR16:$src), (FMV_X_H FPR16:$src)>; } // Predicates = [HasStdExtZfhOrZfhmin] let Predicates = [HasStdExtZfh, IsRV32] in { diff --git a/llvm/test/CodeGen/RISCV/rv64zfh-half-convert.ll b/llvm/test/CodeGen/RISCV/rv64zfh-half-convert.ll --- a/llvm/test/CodeGen/RISCV/rv64zfh-half-convert.ll +++ b/llvm/test/CodeGen/RISCV/rv64zfh-half-convert.ll @@ -79,8 +79,6 @@ ; RV64IZFH: # %bb.0: ; RV64IZFH-NEXT: fadd.h ft0, fa0, fa1 ; RV64IZFH-NEXT: fmv.x.h a0, ft0 -; RV64IZFH-NEXT: slli a0, a0, 48 -; RV64IZFH-NEXT: srai a0, a0, 48 ; RV64IZFH-NEXT: ret %1 = fadd half %a, %b %2 = bitcast half %1 to i16