This is an archive of the discontinued LLVM Phabricator instance.

[clang-ppc64-aix] Set OBJECT_MODE an a builder wide env
ClosedPublic

Authored by daltenty on Feb 1 2022, 8:56 AM.

Details

Summary

Currently we pass this env to the build factory, but that means it only gets propogated to those factory steps which remember to pass the env into their respective shell commands.

On AIX, it's important that this env remain constant accross the cmake/ninja/lit invocations or we will get into strange mixed bitmode situations, so set it as a build env that will be inherited by all shell commands by default.

Diff Detail

Event Timeline

daltenty created this revision.Feb 1 2022, 8:56 AM
daltenty requested review of this revision.Feb 1 2022, 8:56 AM
daltenty edited the summary of this revision. (Show Details)
daltenty set the repository for this revision to rZORG LLVM Github Zorg.Feb 1 2022, 9:18 AM
ZarkoCA accepted this revision.Feb 1 2022, 9:27 AM

I don't know whether it's an issue that the patch is missing context but the change is good, Thanks @daltenty

This revision is now accepted and ready to land.Feb 1 2022, 9:27 AM
daltenty updated this revision to Diff 404972.Feb 1 2022, 9:29 AM

Fix missing context on diff

daltenty updated this revision to Diff 404973.Feb 1 2022, 9:31 AM

Slightly tweak whitespace formatting

This revision was landed with ongoing or failed builds.Feb 1 2022, 11:37 AM
This revision was automatically updated to reflect the committed changes.