Page MenuHomePhabricator
Differential D118637

[Libomptarget] Run GPU offloading tests using the new driver
ClosedPublic
Actions

Authored by jhuber6 on Jan 31 2022, 11:43 AM.

Details

Reviewers
jdoerfert
Meinersbur
JonChesterfield
ronlieb
Commits
rG0ac799b5c977: [Libomptarget] Run GPU offloading tests using the new drvier
Summary

This patch adds a new target to the tests to run using the new driver as
the method for generating offloading code.

Depends on D116541

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 31 2022, 11:43 AM
Herald added a subscriber: mgorny. · View Herald TranscriptJan 31 2022, 11:43 AM
jhuber6 requested review of this revision.Jan 31 2022, 11:43 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 11:43 AM
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
Harbormaster completed remote builds in B146720: Diff 404644.Jan 31 2022, 11:44 AM
jhuber6 updated this revision to Diff 404649.Jan 31 2022, 11:50 AM

Adding XFAIL to test.

Harbormaster completed remote builds in B146725: Diff 404649.Jan 31 2022, 11:51 AM
JonChesterfield retitled this revision from [Libomptarget] Run GPU offloading tests using the new drvier to [Libomptarget] Run GPU offloading tests using the new driver.Jan 31 2022, 11:59 AM
JonChesterfield added inline comments.
openmp/libomptarget/test/lit.cfg
114

You need to generalise / replace this function to avoid passing nvptx64-newDriver or similar as the triple

jhuber6 updated this revision to Diff 404663.Jan 31 2022, 12:19 PM

Addressing triple and adding test for static linking.

Harbormaster completed remote builds in B146734: Diff 404663.Jan 31 2022, 12:20 PM
jhuber6 updated this revision to Diff 404725.Jan 31 2022, 2:04 PM

Add AMDGPU

Herald added subscribers: kerbowa, jvesely. · View Herald TranscriptJan 31 2022, 2:04 PM
JonChesterfield accepted this revision.Jan 31 2022, 2:12 PM

Looks good. We can land this and revert with greater knowledge if the amdgpu buildbot fails on it.

openmp/libomptarget/CMakeLists.txt
40

Could drop the amdgcn-amd-amdhsa and nvptx64-nvidia-cuda lines in passing, I should have removed them previously. Or leave them and we'll remove the -newRTL ones instead of renaming them.

openmp/libomptarget/test/lit.cfg
121

LG. We should drop this newRTL thing at some point.

This revision is now accepted and ready to land.Jan 31 2022, 2:12 PM
jhuber6 added inline comments.Jan 31 2022, 2:13 PM
openmp/libomptarget/test/lit.cfg
121

Yeah, I'll soon make a patch that removes the old runtime.

Harbormaster completed remote builds in B146769: Diff 404725.Jan 31 2022, 2:27 PM
Closed by commit rG0ac799b5c977: [Libomptarget] Run GPU offloading tests using the new drvier (authored by jhuber6). · Explain WhyJan 31 2022, 8:13 PM
This revision was automatically updated to reflect the committed changes.
jhuber6 added a commit: rG0ac799b5c977: [Libomptarget] Run GPU offloading tests using the new drvier.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
2 lines
plugins/
amdgpu/
2 lines
cuda/
2 lines
test/
6 lines
offloading/
29 lines
unified_shared_memory/
2 lines

Diff 404799

View Options

openmp/libomptarget/CMakeLists.txt

Loading...
View Options

openmp/libomptarget/plugins/amdgpu/CMakeLists.txt

Loading...
View Options

openmp/libomptarget/plugins/cuda/CMakeLists.txt

Loading...
View Options

openmp/libomptarget/test/lit.cfg

Loading...
View Options

openmp/libomptarget/test/offloading/static_linking.c

Loading...
View Options

openmp/libomptarget/test/unified_shared_memory/api.c

Loading...