diff --git a/libcxx/include/CMakeLists.txt b/libcxx/include/CMakeLists.txt --- a/libcxx/include/CMakeLists.txt +++ b/libcxx/include/CMakeLists.txt @@ -28,6 +28,7 @@ __algorithm/half_positive.h __algorithm/in_in_out_result.h __algorithm/in_in_result.h + __algorithm/in_out_out_result.h __algorithm/in_out_result.h __algorithm/includes.h __algorithm/inplace_merge.h diff --git a/libcxx/include/__algorithm/in_out_out_result.h b/libcxx/include/__algorithm/in_out_out_result.h new file mode 100644 --- /dev/null +++ b/libcxx/include/__algorithm/in_out_out_result.h @@ -0,0 +1,48 @@ +// -*- C++ -*- +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#ifndef _LIBCPP___ALGORITHM_IN_OUT_OUT_RESULT_H +#define _LIBCPP___ALGORITHM_IN_OUT_OUT_RESULT_H + +#include <__concepts/convertible_to.h> +#include <__config> +#include <__utility/move.h> + +_LIBCPP_BEGIN_NAMESPACE_STD + +#ifndef _LIBCPP_HAS_NO_CONCEPTS + +namespace ranges { +template +struct in_out_out_result { + [[no_unique_address]] _I1 in; + [[no_unique_address]] _O1 out1; + [[no_unique_address]] _O2 out2; + + template + requires convertible_to && convertible_to && convertible_to + _LIBCPP_HIDE_FROM_ABI constexpr + operator in_out_out_result<_II1, _OO1, _OO2>() const& { + return {in, out1, out2}; + } + + template + requires convertible_to<_I1, _II1> && convertible_to<_O1, _OO1> && convertible_to<_O2, _OO2> + _LIBCPP_HIDE_FROM_ABI constexpr + operator in_out_out_result<_II1, _OO1, _OO2>() && { + return {_VSTD::move(in), _VSTD::move(out1), _VSTD::move(out2)}; + } +}; +} // namespace ranges + +#endif // _LIBCPP_HAS_NO_CONCEPTS + +_LIBCPP_END_NAMESPACE_STD + +#endif // _LIBCPP___ALGORITHM_IN_OUT_OUT_RESULT_H diff --git a/libcxx/include/algorithm b/libcxx/include/algorithm --- a/libcxx/include/algorithm +++ b/libcxx/include/algorithm @@ -24,6 +24,9 @@ template struct in_in_out_result; // since C++20 + + template + struct in_out_out_result; // since C++20 } template @@ -701,6 +704,7 @@ #include <__algorithm/half_positive.h> #include <__algorithm/in_in_out_result.h> #include <__algorithm/in_in_result.h> +#include <__algorithm/in_out_out_result.h> #include <__algorithm/in_out_result.h> #include <__algorithm/includes.h> #include <__algorithm/inplace_merge.h> diff --git a/libcxx/include/module.modulemap b/libcxx/include/module.modulemap --- a/libcxx/include/module.modulemap +++ b/libcxx/include/module.modulemap @@ -248,6 +248,7 @@ module half_positive { private header "__algorithm/half_positive.h" } module in_in_out_result { private header "__algorithm/in_in_out_result.h" } module in_in_result { private header "__algorithm/in_in_result.h" } + module in_out_out_result { private header "__algorithm/in_out_out_result.h" } module in_out_result { private header "__algorithm/in_out_result.h" } module includes { private header "__algorithm/includes.h" } module inplace_merge { private header "__algorithm/inplace_merge.h" } diff --git a/libcxx/test/libcxx/diagnostics/detail.headers/algorithm/in_out_out_result.module.verify.cpp b/libcxx/test/libcxx/diagnostics/detail.headers/algorithm/in_out_out_result.module.verify.cpp new file mode 100644 --- /dev/null +++ b/libcxx/test/libcxx/diagnostics/detail.headers/algorithm/in_out_out_result.module.verify.cpp @@ -0,0 +1,15 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +// REQUIRES: modules-build + +// WARNING: This test was generated by 'generate_private_header_tests.py' +// and should not be edited manually. + +// expected-error@*:* {{use of private header from outside its module: '__algorithm/in_out_out_result.h'}} +#include <__algorithm/in_out_out_result.h> diff --git a/libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp b/libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp --- a/libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp +++ b/libcxx/test/std/algorithms/algorithms.results/in_in_out_result.pass.cpp @@ -75,7 +75,7 @@ constexpr bool test() { { - std::ranges::in_in_out_result res{10L, 0., 1.f}; + std::ranges::in_in_out_result res{10, 0., 1.f}; assert(res.in1 == 10); assert(res.in2 == 0.); assert(res.out == 1.f); diff --git a/libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp b/libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp new file mode 100644 --- /dev/null +++ b/libcxx/test/std/algorithms/algorithms.results/in_out_out_result.pass.cpp @@ -0,0 +1,108 @@ +//===----------------------------------------------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +// UNSUPPORTED: c++03, c++11, c++14, c++17 +// UNSUPPORTED: libcpp-no-concepts +// UNSUPPORTED: libcpp-has-no-incomplete-ranges + +// template +// struct in_out_out_result; + +#include +#include +#include + +#include "MoveOnly.h" + +template +struct ConvertibleFrom { + constexpr ConvertibleFrom(T c) : content{c} {} + T content; +}; + +struct A { + explicit A(int); +}; +// conversion is not implicit +static_assert(!std::is_constructible_v, + std::ranges::in_out_out_result>); + +struct B { + B(int); +}; +static_assert(std::is_constructible_v, std::ranges::in_out_out_result>); +static_assert(std::is_constructible_v, std::ranges::in_out_out_result&>); +static_assert(std::is_constructible_v, const std::ranges::in_out_out_result>); +static_assert(std::is_constructible_v, const std::ranges::in_out_out_result&>); + +struct C { + C(int&); +}; +static_assert(!std::is_constructible_v, std::ranges::in_out_out_result&>); + +static_assert(std::is_convertible_v&, + std::ranges::in_out_out_result>); +static_assert(std::is_convertible_v&, + std::ranges::in_out_out_result>); +static_assert(std::is_convertible_v&&, + std::ranges::in_out_out_result>); +static_assert(std::is_convertible_v&&, + std::ranges::in_out_out_result>); + +struct NotConvertible {}; +static_assert(!std::is_convertible_v, + std::ranges::in_out_out_result>); +static_assert(!std::is_convertible_v, + std::ranges::in_out_out_result>); +static_assert(!std::is_convertible_v, + std::ranges::in_out_out_result>); + +static_assert(std::is_constructible_v, + std::ranges::in_out_out_result&>); + +static_assert(std::is_move_constructible_v>); +static_assert(std::is_move_constructible_v>); +static_assert(std::is_move_constructible_v>); + +static_assert(!std::is_copy_constructible_v>); +static_assert(!std::is_copy_constructible_v>); +static_assert(!std::is_copy_constructible_v>); + +constexpr bool test() { + { + std::ranges::in_out_out_result res{10, 0., 1.f}; + assert(res.in == 10); + assert(res.out1 == 0.); + assert(res.out2 == 1.f); + std::ranges::in_out_out_result, ConvertibleFrom, ConvertibleFrom> res2 = res; + assert(res2.in.content == 10); + assert(res2.out1.content == 0.); + assert(res2.out2.content == 1.f); + } + { + std::ranges::in_out_out_result res1{MoveOnly{}, 0, 0}; + assert(res1.in.get() == 1); + auto res2 = static_cast>(std::move(res1)); + assert(res1.in.get() == 0); + assert(res2.in.get() == 1); + } + { + auto [in, out1, out2] = std::ranges::in_out_out_result{1, 2, 3}; + assert(in == 1); + assert(out1 == 2); + assert(out2 == 3); + } + return true; +} + +int main(int, char**) { + test(); + static_assert(test()); + + return 0; +} diff --git a/libcxx/test/std/algorithms/algorithms.results/no_unique_address.compile.pass.cpp b/libcxx/test/std/algorithms/algorithms.results/no_unique_address.compile.pass.cpp --- a/libcxx/test/std/algorithms/algorithms.results/no_unique_address.compile.pass.cpp +++ b/libcxx/test/std/algorithms/algorithms.results/no_unique_address.compile.pass.cpp @@ -35,3 +35,12 @@ static_assert(sizeof(std::ranges::in_in_out_result) == 2); static_assert(sizeof(std::ranges::in_in_out_result) == sizeof(int)); static_assert(sizeof(std::ranges::in_in_out_result) == 3); + +static_assert(sizeof(std::ranges::in_out_out_result) == 2 * sizeof(int)); +static_assert(sizeof(std::ranges::in_out_out_result) == 2 * sizeof(int)); +static_assert(sizeof(std::ranges::in_out_out_result) == 2 * sizeof(int)); +static_assert(sizeof(std::ranges::in_out_out_result) == 2); +static_assert(sizeof(std::ranges::in_out_out_result) == 2); +static_assert(sizeof(std::ranges::in_out_out_result) == 2); +static_assert(sizeof(std::ranges::in_out_out_result) == sizeof(int)); +static_assert(sizeof(std::ranges::in_out_out_result) == 3);