Page MenuHomePhabricator

[Libomptarget] Reduce shared memory stack size to 512 and a message when it is exceeded
ClosedPublic

Authored by jhuber6 on Jan 31 2022, 9:18 AM.

Details

Summary

Reduces the shared memory size used for globalization to 512 bytes from
2048 to reduce the pressure on shared memory. This patch ado adds a
debug mesage to indicate when the shared memory was insufficient.

Diff Detail

Event Timeline

jhuber6 created this revision.Jan 31 2022, 9:18 AM
jhuber6 requested review of this revision.Jan 31 2022, 9:18 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 31 2022, 9:18 AM

typo in the commit message.

openmp/libomptarget/DeviceRTL/src/State.cpp
140

Be more explicit here, or, probably better, use a "runtime remark" [OMPR1000] Shared memory stack full, fallback to dynamic allocation of global memory (=slow)

jhuber6 updated this revision to Diff 404586.Jan 31 2022, 10:00 AM

Being more specific.

jhuber6 updated this revision to Diff 404636.Jan 31 2022, 11:33 AM

fix missing word

This revision is now accepted and ready to land.Jan 31 2022, 11:33 AM