Page MenuHomePhabricator

StackMap: FastISel: Add an appropriate number of immediate operands to the frame setup instruction.
ClosedPublic

Authored by arphaman on Aug 7 2015, 4:26 PM.

Details

Summary

This patch ensures that the stack map lowering code in FastISel adds an appropriate number of immediate operands for the frame setup instruction.

The previous code added just one immediate operand, which was fine for a target like AArch64, but on X86 the ADJUSTCALLSTACKDOWN64 instruction needs two explicit operands, and this caused the machine verifier to report an error when the old code added just one.

Diff Detail

Repository
rL LLVM

Event Timeline

arphaman updated this revision to Diff 31556.Aug 7 2015, 4:26 PM
arphaman retitled this revision from to StackMap: FastISel: Add an appropriate number of immediate operands to the frame setup instruction..
arphaman updated this object.
arphaman set the repository for this revision to rL LLVM.
arphaman added a subscriber: llvm-commits.
ributzka accepted this revision.Aug 10 2015, 9:22 AM
ributzka edited edge metadata.

LGTM

Could you also add a test for PPC?

This revision is now accepted and ready to land.Aug 10 2015, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Thanks, the committed patch also includes the PPC test.