This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP] Fix link error on Windows caused by `interop` functions
ClosedPublic

Authored by tianshilei1992 on Jan 28 2022, 7:47 PM.

Details

Summary

This patch fixes the link error on Windows caused by interop
functions.

Diff Detail

Event Timeline

tianshilei1992 created this revision.Jan 28 2022, 7:47 PM
tianshilei1992 requested review of this revision.Jan 28 2022, 7:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 7:47 PM

@mstorsjo can you give it a shot? I don't have access to Window system.

I didn’t try this yet, but you need to change the ordinals of the new exports in the dllexports file too.

I didn’t try this yet, but you need to change the ordinals of the new exports in the dllexports file too.

It's been merged.

mstorsjo accepted this revision.Jan 29 2022, 5:21 AM

I didn’t try this yet, but you need to change the ordinals of the new exports in the dllexports file too.

It's been merged.

Oh, right, sorry, I missed that.

I tested this, and building works fine now again. Thanks!

This revision is now accepted and ready to land.Jan 29 2022, 5:21 AM