Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Fix CMake build on Windows
ClosedPublic
Actions

Authored by omalyshe on Aug 5 2015, 8:00 AM.

Details

Reviewers

jlpeyton
openmp-commits
ismail

Commits

rG3c4dd1c9f168: Fix link error on Windows when LIBOMP_USE_DEBUGGER is off
rOMP244217: Fix link error on Windows when LIBOMP_USE_DEBUGGER is off
rL244217: Fix link error on Windows when LIBOMP_USE_DEBUGGER is off

Summary

Two symbols for the external debugger support were incorrectly exported when LIBOMP_USE_DEBUGGER=off.

Diff Detail

Repository: rL LLVM

Event Timeline

omalyshe updated this revision to Diff 31352.Aug 5 2015, 8:00 AM

omalyshe retitled this revision from to Fix CMake build on Windows .

omalyshe updated this object.

omalyshe added reviewers: ismail, openmp-commits, jlpeyton.

omalyshe added subscribers: omalyshe, openmp-commits.

LGTM. Fixes the build for me on Windows.

This revision is now accepted and ready to land.Aug 5 2015, 8:49 AM

Closed by commit rL244217: Fix link error on Windows when LIBOMP_USE_DEBUGGER is off (authored by jlpeyton). · Explain WhyAug 6 2015, 8:17 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

openmp/

trunk/

runtime/

cmake/

LibompHandleFlags.cmake

1 line

src/

dllexports

4 lines

Diff 31449

View Options

openmp/trunk/runtime/cmake/LibompHandleFlags.cmake