Page MenuHomePhabricator

Improve lit "native" feature to check if the native backend is builtin
ClosedPublic

Authored by mehdi_amini on Aug 3 2015, 12:59 PM.

Details

Reviewers
mehdi_amini
Summary

The goal is to have 'ninja check' passing even if the X86 backend is
not built.

Diff Detail

Event Timeline

mehdi_amini retitled this revision from to Improve lit "native" feature to check if the native backend is builtin.
mehdi_amini updated this object.
mehdi_amini added a subscriber: llvm-commits.
filcab added a subscriber: filcab.Aug 3 2015, 10:59 PM
filcab added inline comments.
test/lit.cfg
340

Interesting, target_triple seems to be set (in cmake) to LLVM_HOST_TRIPLE (unless explicitly set), without caring about the backends being compiled.

Should we change the target_triple logic instead of this, though?

What's the value of "target_triple" when we don't have the current target selected? Is that value appropriate?

mehdi_amini accepted this revision.Aug 5 2015, 10:34 AM
mehdi_amini added a reviewer: mehdi_amini.
This revision is now accepted and ready to land.Aug 5 2015, 10:34 AM