Index: mlir/test/mlir-tblgen/op-side-effects.td =================================================================== --- mlir/test/mlir-tblgen/op-side-effects.td +++ mlir/test/mlir-tblgen/op-side-effects.td @@ -26,8 +26,8 @@ // CHECK: void SideEffectOpA::getEffects // CHECK: for (::mlir::Value value : getODSOperands(0)) // CHECK: effects.emplace_back(::mlir::MemoryEffects::Read::get(), value, ::mlir::SideEffects::DefaultResource::get()); -// CHECK: effects.emplace_back(::mlir::MemoryEffects::Read::get(), symbol(), ::mlir::SideEffects::DefaultResource::get()); -// CHECK: effects.emplace_back(::mlir::MemoryEffects::Write::get(), flat_symbol(), ::mlir::SideEffects::DefaultResource::get()); +// CHECK: effects.emplace_back(::mlir::MemoryEffects::Read::get(), symbolAttr(), ::mlir::SideEffects::DefaultResource::get()); +// CHECK: effects.emplace_back(::mlir::MemoryEffects::Write::get(), flat_symbolAttr(), ::mlir::SideEffects::DefaultResource::get()); // CHECK: if (auto symbolRef = optional_symbolAttr()) // CHECK: effects.emplace_back(::mlir::MemoryEffects::Read::get(), symbolRef, ::mlir::SideEffects::DefaultResource::get()); // CHECK: for (::mlir::Value value : getODSResults(0)) Index: mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp =================================================================== --- mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp +++ mlir/tools/mlir-tblgen/OpDefinitionsGen.cpp @@ -2058,7 +2058,7 @@ << llvm::formatv(addEffectCode, effect, "symbolRef, ", resource) .str(); } else { - body << llvm::formatv(addEffectCode, effect, attr->name + "(), ", + body << llvm::formatv(addEffectCode, effect, attr->name + "Attr(), ", resource) .str(); }