Index: include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h =================================================================== --- include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h +++ include/clang/StaticAnalyzer/Core/PathSensitive/ProgramState.h @@ -330,6 +330,18 @@ ProgramStateRef addTaint(const MemRegion *R, TaintTagType Kind = TaintTagGeneric) const; + /// Create a new state in which the statement is marked as non-tainted. + ProgramStateRef removeTaint(const Stmt *S, const LocationContext *LCtx, + TaintTagType Kind = TaintTagGeneric) const; + + /// Create a new state in which the symbol is marked as non-tainted. + ProgramStateRef removeTaint(SymbolRef S, TaintTagType Kind = TaintTagGeneric) + const; + + /// Create a new state in which the region symbol is marked as non-tainted. + ProgramStateRef removeTaint(const MemRegion *R, TaintTagType Kind = + TaintTagGeneric) const; + /// Check if the statement is tainted in the current state. bool isTainted(const Stmt *S, const LocationContext *LCtx, TaintTagType Kind = TaintTagGeneric) const; @@ -428,6 +440,13 @@ InvalidatedSymbols *IS, RegionAndSymbolInvalidationTraits *HTraits, const CallEvent *Call) const; + + SymbolRef + getSymbolFromStmt(const Stmt *S, const LocationContext *LCtx) const; + + const MemRegion* + getRegionFromStmt(const Stmt *S, const LocationContext *LCtx) const; + }; //===----------------------------------------------------------------------===// Index: lib/StaticAnalyzer/Core/ProgramState.cpp =================================================================== --- lib/StaticAnalyzer/Core/ProgramState.cpp +++ lib/StaticAnalyzer/Core/ProgramState.cpp @@ -648,17 +648,28 @@ return true; } -ProgramStateRef ProgramState::addTaint(const Stmt *S, - const LocationContext *LCtx, - TaintTagType Kind) const { +SymbolRef ProgramState::getSymbolFromStmt(const Stmt *S, const LocationContext + *LCtx) const { if (const Expr *E = dyn_cast_or_null(S)) S = E->IgnoreParens(); - SymbolRef Sym = getSVal(S, LCtx).getAsSymbol(); + return getSVal(S, LCtx).getAsSymbol(); + +} + +const MemRegion* ProgramState::getRegionFromStmt(const Stmt *S, const LocationContext + *LCtx) const { + return getSVal(S, LCtx).getAsRegion(); +} + +ProgramStateRef ProgramState::addTaint(const Stmt *S, + const LocationContext *LCtx, + TaintTagType Kind) const { + SymbolRef Sym = getSymbolFromStmt(S, LCtx); if (Sym) return addTaint(Sym, Kind); - const MemRegion *R = getSVal(S, LCtx).getAsRegion(); + const MemRegion *R = getRegionFromStmt(S, LCtx); addTaint(R, Kind); // Cannot add taint, so just return the state. @@ -684,6 +695,38 @@ return NewState; } +ProgramStateRef ProgramState::removeTaint(const Stmt *S, const LocationContext + *LCtx, TaintTagType Kind) const { + SymbolRef Sym = getSymbolFromStmt(S, LCtx); + if (Sym) + return removeTaint(Sym, Kind); + + const MemRegion *R = getRegionFromStmt(S, LCtx); + removeTaint(R, Kind); + + // Cannot remove taint, so just return the state. + return this; +} + +ProgramStateRef ProgramState::removeTaint(const MemRegion *R, TaintTagType Kind) + const { + if (const SymbolicRegion *SR = dyn_cast_or_null(R)) + return removeTaint(SR->getSymbol(), Kind); + return this; +} + +ProgramStateRef ProgramState::removeTaint(SymbolRef Sym, TaintTagType Kind) + const { + // If this is a symbol cast, remove the cast before removing the taint. Taint + // is cast agnostic. + while (const SymbolCast *SC = dyn_cast(Sym)) + Sym = SC->getOperand(); + + ProgramStateRef NewState = remove(Sym); + assert(NewState); + return NewState; +} + bool ProgramState::isTainted(const Stmt *S, const LocationContext *LCtx, TaintTagType Kind) const { if (const Expr *E = dyn_cast_or_null(S))