diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h --- a/mlir/include/mlir/Transforms/DialectConversion.h +++ b/mlir/include/mlir/Transforms/DialectConversion.h @@ -22,7 +22,6 @@ // Forward declarations. class Block; class ConversionPatternRewriter; -class FuncOp; class MLIRContext; class Operation; class Type; @@ -507,11 +506,6 @@ patterns, converter); } -/// Add a pattern to the given pattern list to convert the signature of a FuncOp -/// with the given type converter. -void populateFuncOpTypeConversionPattern(RewritePatternSet &patterns, - TypeConverter &converter); - //===----------------------------------------------------------------------===// // Conversion PatternRewriter //===----------------------------------------------------------------------===// diff --git a/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp b/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp --- a/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp +++ b/mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp @@ -983,7 +983,7 @@ llvmConverter.addConversion(AsyncRuntimeTypeConverter::convertAsyncTypes); // Convert async types in function signatures and function calls. - populateFuncOpTypeConversionPattern(patterns, converter); + populateFunctionLikeTypeConversionPattern(patterns, converter); populateCallOpTypeConversionPattern(patterns, converter); // Convert return operations inside async.execute regions. diff --git a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp --- a/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp +++ b/mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp @@ -124,7 +124,7 @@ .addLegalDialect(); // Populate with rules and apply rewriting rules. - populateFuncOpTypeConversionPattern(patterns, converter); + populateFunctionLikeTypeConversionPattern(patterns, converter); populateCallOpTypeConversionPattern(patterns, converter); populateSparseTensorConversionPatterns(converter, patterns); if (failed(applyPartialConversion(getOperation(), target, diff --git a/mlir/lib/Dialect/StandardOps/Transforms/FuncBufferize.cpp b/mlir/lib/Dialect/StandardOps/Transforms/FuncBufferize.cpp --- a/mlir/lib/Dialect/StandardOps/Transforms/FuncBufferize.cpp +++ b/mlir/lib/Dialect/StandardOps/Transforms/FuncBufferize.cpp @@ -31,7 +31,7 @@ RewritePatternSet patterns(context); ConversionTarget target(*context); - populateFuncOpTypeConversionPattern(patterns, typeConverter); + populateFunctionLikeTypeConversionPattern(patterns, typeConverter); target.addDynamicallyLegalOp([&](FuncOp op) { return typeConverter.isSignatureLegal(op.getType()) && typeConverter.isLegal(&op.getBody()); diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp --- a/mlir/lib/Transforms/Utils/DialectConversion.cpp +++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp @@ -3095,11 +3095,6 @@ functionLikeOpName, patterns.getContext(), converter); } -void mlir::populateFuncOpTypeConversionPattern(RewritePatternSet &patterns, - TypeConverter &converter) { - populateFunctionLikeTypeConversionPattern(patterns, converter); -} - //===----------------------------------------------------------------------===// // ConversionTarget //===----------------------------------------------------------------------===// diff --git a/mlir/test/lib/Dialect/Test/TestPatterns.cpp b/mlir/test/lib/Dialect/Test/TestPatterns.cpp --- a/mlir/test/lib/Dialect/Test/TestPatterns.cpp +++ b/mlir/test/lib/Dialect/Test/TestPatterns.cpp @@ -655,7 +655,7 @@ TestNestedOpCreationUndoRewrite, TestReplaceEraseOp, TestCreateUnregisteredOp>(&getContext()); patterns.add(&getContext(), converter); - mlir::populateFuncOpTypeConversionPattern(patterns, converter); + mlir::populateFunctionLikeTypeConversionPattern(patterns, converter); mlir::populateCallOpTypeConversionPattern(patterns, converter); // Define the conversion target used for the test. @@ -1120,7 +1120,7 @@ TestTestSignatureConversionNoConverter>(converter, &getContext()); patterns.add(&getContext()); - mlir::populateFuncOpTypeConversionPattern(patterns, converter); + mlir::populateFunctionLikeTypeConversionPattern(patterns, converter); if (failed(applyPartialConversion(getOperation(), target, std::move(patterns))))