This is an archive of the discontinued LLVM Phabricator instance.

Differential D116429

Do not install MLIR Object libraries used for assembling the C API (NFC)
AcceptedPublic

Authored by mehdi_amini on Dec 30 2021, 5:41 PM.

Details

Reviewers
sylvestre.ledru
stellaraccident
bondhugula
stephenneuendorffer
Summary

Without this, ninja install will lead to installing the following:

lib/objects-Release/obj.MLIRCAPISparseTensor/SparseTensor.cpp.o
lib/objects-Release/obj.MLIRCAPISparseTensor/SparseTensorPasses.cpp.o
lib/objects-Release/obj.MLIRCAPIShape/Shape.cpp.o
lib/objects-Release/obj.MLIRCAPIDebug/Debug.cpp.o
lib/objects-Release/obj.MLIRCAPILLVM/LLVM.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/AffineExpr.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/Support.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/IR.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/Diagnostics.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/Pass.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/BuiltinAttributes.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/AffineMap.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/BuiltinTypes.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/DialectHandle.cpp.o
lib/objects-Release/obj.MLIRCAPIIR/IntegerSet.cpp.o
lib/objects-Release/obj.MLIRCAPIExecutionEngine/ExecutionEngine.cpp.o
lib/objects-Release/obj.MLIRCAPIRegistration/Registration.cpp.o
lib/objects-Release/obj.MLIRCAPILinalg/Linalg.cpp.o
lib/objects-Release/obj.MLIRCAPILinalg/LinalgPasses.cpp.o
lib/objects-Release/obj.MLIRCAPITensor/Tensor.cpp.o
lib/objects-Release/obj.MLIRCAPITransforms/Passes.cpp.o
lib/objects-Release/obj.MLIRCAPIStandard/Standard.cpp.o
lib/objects-Release/obj.MLIRCAPISCF/SCF.cpp.o
lib/objects-Release/obj.MLIRCAPIAsync/AsyncPasses.cpp.o
lib/objects-Release/obj.MLIRCAPIAsync/Async.cpp.o
lib/objects-Release/obj.MLIRCAPIGPU/GPUPasses.cpp.o
lib/objects-Release/obj.MLIRCAPIGPU/GPU.cpp.o
lib/objects-Release/obj.MLIRCAPIInterfaces/Interfaces.cpp.o
lib/objects-Release/obj.MLIRCAPIConversion/Passes.cpp.o
lib/objects-Release/obj.MLIRCAPIPythonTestDialect/PythonTestCAPI.cpp.o

Diff Detail

Event Timeline

mehdi_amini created this revision.Dec 30 2021, 5:41 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 20 others. · View Herald TranscriptDec 30 2021, 5:41 PM
mehdi_amini requested review of this revision.Dec 30 2021, 5:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 30 2021, 5:41 PM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added reviewers: sylvestre.ledru, stellaraccident.Dec 30 2021, 5:42 PM
Harbormaster completed remote builds in B141069: Diff 396738.Dec 30 2021, 5:55 PM
sylvestre.ledru accepted this revision.Dec 31 2021, 1:55 AM

thanks
I am doing an ugly rm -rf to remove them after install ;)

This revision is now accepted and ready to land.Dec 31 2021, 1:55 AM
stellaraccident added a comment.Dec 31 2021, 7:37 AM

There are people relying on this. Can you just disable this option by default until we find something better? That way they can still opt in.

stellaraccident added reviewers: bondhugula, stephenneuendorffer.Dec 31 2021, 7:38 AM

You'll then need to enable that option when building the examples project test (which uses these and is likely why the bots are failing).

Revision Contents

PathSize
mlir/
lib/
CAPI/
2 lines
test/
python/
lib/
2 lines

Diff 396738

mlir/lib/CAPI/CMakeLists.txt

# For upstream, we accumulate all libraries into the MLIR_CAPI_LIBRARIES # For upstream, we accumulate all libraries into the MLIR_CAPI_LIBRARIES
# property via a custom wrapper function. This is then used to create an # property via a custom wrapper function. This is then used to create an
# aggregate below. # aggregate below.
set_property(GLOBAL APPEND PROPERTY MLIR_CAPI_LIBRARIES) set_property(GLOBAL APPEND PROPERTY MLIR_CAPI_LIBRARIES)
function(add_mlir_upstream_c_api_library name) function(add_mlir_upstream_c_api_library name)
add_mlir_public_c_api_library(${name} ${ARGN}) add_mlir_public_c_api_library(${name} ${ARGN} DISABLE_INSTALL)
set_property(GLOBAL APPEND PROPERTY MLIR_CAPI_LIBRARIES ${name}) set_property(GLOBAL APPEND PROPERTY MLIR_CAPI_LIBRARIES ${name})
endfunction() endfunction()
add_subdirectory(Debug) add_subdirectory(Debug)
add_subdirectory(Dialect) add_subdirectory(Dialect)
add_subdirectory(Conversion) add_subdirectory(Conversion)
add_subdirectory(ExecutionEngine) add_subdirectory(ExecutionEngine)
add_subdirectory(Interfaces) add_subdirectory(Interfaces)
Show All 21 Lines

mlir/test/python/lib/CMakeLists.txt

Show All 23 Linesadd_mlir_public_c_api_library(MLIRCAPIPythonTestDialect
DEPENDS DEPENDS
MLIRPythonTestIncGen MLIRPythonTestIncGen
LINK_LIBS PUBLIC LINK_LIBS PUBLIC
MLIRCAPIInterfaces MLIRCAPIInterfaces
MLIRCAPIIR MLIRCAPIIR
MLIRCAPIRegistration MLIRCAPIRegistration
MLIRPythonTestDialect MLIRPythonTestDialect
DISABLE_INSTALL
) )