diff --git a/clang-tools-extra/clangd/refactor/Rename.cpp b/clang-tools-extra/clangd/refactor/Rename.cpp --- a/clang-tools-extra/clangd/refactor/Rename.cpp +++ b/clang-tools-extra/clangd/refactor/Rename.cpp @@ -455,7 +455,7 @@ } llvm::Error makeError(InvalidName Reason) { - auto Message = [](InvalidName Reason) { + auto Message = [](const InvalidName &Reason) { switch (Reason.K) { case InvalidName::Keywords: return llvm::formatv("the chosen name \"{0}\" is a keyword", @@ -733,7 +733,7 @@ return makeError(ReasonToReject::SameName); auto Invalid = checkName(RenameDecl, RInputs.NewName); if (Invalid) - return makeError(*Invalid); + return makeError(std::move(*Invalid)); auto Reject = renameable(RenameDecl, RInputs.MainFilePath, RInputs.Index); if (Reject) diff --git a/clang-tools-extra/clangd/unittests/RenameTests.cpp b/clang-tools-extra/clangd/unittests/RenameTests.cpp --- a/clang-tools-extra/clangd/unittests/RenameTests.cpp +++ b/clang-tools-extra/clangd/unittests/RenameTests.cpp @@ -1060,6 +1060,11 @@ )cpp", "conflict", !HeaderFile, "Conflict"}, + {R"cpp( + int V^ar; + )cpp", + "\"const\" is a keyword", !HeaderFile, "const"}, + {R"cpp(// Trying to rename into the same name, SameName == SameName. void func() { int S^ameName;