Page MenuHomePhabricator
Differential D115944

[MLIR] Add a missing increment in LLVM struct type conversion
AcceptedPublic
Actions

Authored by kiranchandramohan on Dec 17 2021, 8:51 AM.

Details

Reviewers
ftynse
rriddle
mehdi_amini
wsmoses
Summary

Not 100% sure about this change and also not clear what is the test that will trigger this.
Please suggest.

Diff Detail

Event Timeline

kiranchandramohan created this revision.Dec 17 2021, 8:51 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 18 others. · View Herald TranscriptDec 17 2021, 8:51 AM
kiranchandramohan requested review of this revision.Dec 17 2021, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 17 2021, 8:51 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
kiranchandramohan edited the summary of this revision. (Show Details)Dec 17 2021, 8:52 AM
Harbormaster completed remote builds in B139856: Diff 395144.Dec 17 2021, 9:12 AM
mehdi_amini added a comment.Dec 17 2021, 5:27 PM

The test is: mlir/test/Conversion/StandardToLLVM/convert-types.mlir

ftynse accepted this revision.Dec 20 2021, 5:07 AM

Thanks!

This revision is now accepted and ready to land.Dec 20 2021, 5:07 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Conversion/
LLVMCommon/
2 lines

Diff 395144

View Options

mlir/lib/Conversion/LLVMCommon/TypeConverter.cpp

Loading...