diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp --- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp +++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp @@ -18395,8 +18395,8 @@ if (StoreSDNode *ST1 = dyn_cast(Chain)) { if (ST->isUnindexed() && ST->isSimple() && ST1->isUnindexed() && ST1->isSimple()) { - if (ST1->getBasePtr() == Ptr && ST1->getValue() == Value && - ST->getMemoryVT() == ST1->getMemoryVT() && + if (OptLevel != CodeGenOpt::None && ST1->getBasePtr() == Ptr && + ST1->getValue() == Value && ST->getMemoryVT() == ST1->getMemoryVT() && ST->getAddressSpace() == ST1->getAddressSpace()) { // If this is a store followed by a store with the same value to the // same location, then the store is dead/noop. diff --git a/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll b/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll new file mode 100644 --- /dev/null +++ b/llvm/test/CodeGen/RISCV/optnone-store-no-combine.ll @@ -0,0 +1,16 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s | FileCheck %s + +; This test verifies that a repeated store is not eliminated with optnone (improves debugging). + +define void @foo(i32* %p) noinline optnone { +; CHECK-LABEL: foo: +; CHECK: # %bb.0: +; CHECK-NEXT: li a1, 8 +; CHECK-NEXT: sw a1, 0(a0) +; CHECK-NEXT: sw a1, 0(a0) +; CHECK-NEXT: ret + store i32 8, i32* %p, align 4 + store i32 8, i32* %p, align 4 + ret void +}