[OpenMP] Add "not" to test dependencies.
ClosedPublic
Actions

Authored by Meinersbur on Dec 9 2021, 9:59 AM.

Details

Reviewers

tianshilei1992
jdenny
JonChesterfield
arsenm
ronl
jhuber6
jyu2
jdoerfert

Commits

rG77e019c23389: [OpenMP] Add "not" to test dependencies.

Summary

The not program is used to test executions prefixed with %libomptarget-run-fail-. Currently not is not used for libomp tests, but might be used in the future and its dependency does not add any additional burden over the already established FileCheck dependency.

Required to add libomptarget testing to the Phabricator pre-merge check (see https://github.com/google/llvm-premerge-checks/issues/368)

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

Meinersbur created this revision.Dec 9 2021, 9:59 AM

Herald added subscribers: guansong, yaxunl, mgorny. · View Herald TranscriptDec 9 2021, 9:59 AM

Meinersbur requested review of this revision.Dec 9 2021, 9:59 AM

Herald added a reviewer: jdoerfert. · View Herald TranscriptDec 9 2021, 9:59 AM

Herald added subscribers: sstefan1, wdng. · View Herald Transcript

Harbormaster completed remote builds in B138476: Diff 393204.Dec 9 2021, 10:32 AM

Thanks!

This revision is now accepted and ready to land.Dec 9 2021, 11:07 AM

Other than the question I added inline, LGTM.

openmp/cmake/OpenMPTesting.cmake
68	Do you know why `not` and `FileCheck` are handled differently here? It might be that D95689 simply overlooked `not`. @tianshilei1992? I'm not sure if this discrepancy is relevant to the problem you're trying to fix, so maybe it should be addressed separately.

Meinersbur added inline comments.Dec 12 2021, 8:32 AM

openmp/cmake/OpenMPTesting.cmake
68	@tianshilei1992 might be the best to answer this question. However, by the motivation D95689, it seems that `LLVM_INSTALL_TOOLCHAIN_ONLY` applies to `not` and `FileCheck` at the same time. hence checking the existence of one implies the existence of the other.