Page MenuHomePhabricator

[libcxxabi] Add -funwind-tables to the test compilation options.
ClosedPublic

Authored by dsanders on Jul 27 2015, 9:02 AM.

Details

Summary

backtrace_test.pass.cpp depends on unwind tables. These are generated by
-funwind-tables which is the default for x86 but not for other targets.

Thanks to Nitesh Jain for helping to narrow this down.

Diff Detail

Event Timeline

dsanders updated this revision to Diff 30700.Jul 27 2015, 9:02 AM
dsanders retitled this revision from to [libcxxabi] Add -funwind-tables to the test compilation options..
dsanders updated this object.
dsanders added subscribers: hans, llvm-commits.
jroelofs accepted this revision.Jul 27 2015, 9:21 AM
jroelofs added a reviewer: jroelofs.
jroelofs added a subscriber: jroelofs.

LGTM... Thanks!

This revision is now accepted and ready to land.Jul 27 2015, 9:21 AM
jroelofs edited edge metadata.Jul 27 2015, 9:22 AM
jroelofs added a subscriber: cfe-commits.

CC-ing cfe-commits (which is where patches to libcxxabi should go).

hans added a comment.Jul 27 2015, 11:19 AM

Should I interpret me being cc'd as a merge request? :-)

dsanders closed this revision.Jul 27 2015, 11:20 AM

Thanks

CC-ing cfe-commits (which is where patches to libcxxabi should go).

Sorry. I sent the other libcxxabi patch to the right list but it looks like habit won this time. Thanks for correcting this.

Should I interpret me being cc'd as a merge request? :-)

Sorry, I forgot to say which ticket it fixes on the review but I remembered for the commit (r243296). It fixes PR24148.
I'm not sure who the code-owner for libcxxabi is though. I could only find libcxx in CODE_OWNERS.txt

> Should I interpret me being cc'd as a merge request? :-)
Sorry, I forgot to say which ticket it fixes on the review but I remembered for the commit (r243296). It fixes PR24148.
I'm not sure who the code-owner for libcxxabi is though. I could only find libcxx in CODE_OWNERS.txt

There should have been a 'yes' in that reply :-). Clearly I'm trying to do too many things at once.

This is committed to trunk but not merged yet since the person we believe to be the code owner hasn't responded yet.

Hans: Are you willing to approve the merge?

I've just noticed Marshal isn't CC'd. That might explain the lack of approval for the merge :-). Added him.

I'm fine with this.

Thanks. Merged to 3.7 branch in r243649.