- Add proxy function for MCAsmParser::Note() to MCAsmParserExtension
- Warn on multiple version_min directives
- Warn if .xxx_min_version does not match target triple
I am not sure if we should warn for UnknownOS. I guess there can be argument both way but we should at least have a test case for it. I am also not sure if you can run i386 asm parser when x86 backend is not built.
The "Triple::OSType ExpectedOS = Triple::UnknownOS;" initialization is only there to avoid uninitialized variable warnings, in practice you will always hit one of the switch cases below it.
I think you are right here. I was looking at the version-min-diagnostics.s test which made the same error when I wrote this. For this test I can switch to the nonexisting thumbv7-apple-macosx.
I was actually referring to what if T.getOS() is UnknownOS. With some more thought, I realize version_min directive will not even parse with -triple armv7-apple. The only case might be interesting is what about armv7-apple-darwin?