Page MenuHomePhabricator

[libunwind] Flip order of extern "C" and attribute(visibility)
ClosedPublic

Authored by rengolin on Jul 24 2015, 8:12 AM.

Details

Summary

GCC doesn't seems to like having the attribute before extern, but
Clang accepts it either way. This patch makes it compile on both.

Diff Detail

Event Timeline

rengolin updated this revision to Diff 30575.Jul 24 2015, 8:12 AM
rengolin retitled this revision from to [libunwind] Flip order of extern "C" and attribute(visibility) .
rengolin updated this object.
rengolin set the repository for this revision to rL LLVM.
rengolin added a subscriber: llvm-commits.
t.p.northover accepted this revision.Jul 24 2015, 9:15 AM
t.p.northover edited edge metadata.

Seems fine to me.

Tim.

This revision is now accepted and ready to land.Jul 24 2015, 9:15 AM
rengolin closed this revision.Jul 24 2015, 12:29 PM

r243147. Thanks!