[Sanitizer] Use CreateDirectoryA for report dirs

[tunz]

Summary

Using _mkdir of CRT in Asan Init leads to launch failure and hanging in Windows.

You can trigger it by calling:

set ASAN_OPTIONS=log_path=a/a/a
.\asan_program.exe

And their crash dump shows the following stack trace:

_guard_dispatch_icall_nop()
__acrt_get_utf8_acp_compatibility_codepage()
_mkdir(const char * path)

I guess there could be a cfg guard in CRT, which may lead to calling uninitialized cfg guard function address. Also, _mkdir supports UTF-8 encoding of the path and calls _wmkdir, but that's not necessary for this case since other file apis in sanitizer_win.cpp assumes only ANSI code case, so it makes sense to use CreateDirectoryA matching other file api calls in the same file.

[tunz]

Set nullptr to the second arg.

[tunz]

fileapi.h is unnecessary

[tejohnson]

I see CreateDirectoryA is also used in the Windows fuzzer support.

lgtm

[tunz]

Thanks for the review. Could you land it on behalf of me? I don't have commit access.

[tunz]

Kindly ping. Can you commit this to main branch?

[tejohnson]

In D114760#3165559, @tunz wrote:

Kindly ping. Can you commit this to main branch?

I'll commit this today.

compiler-rt/lib/sanitizer_common/sanitizer_win.cpp

 // sanitizer_libc.h.
 //===----------------------------------------------------------------------===//
 
 #include "sanitizer_platform.h"
 #if SANITIZER_WINDOWS
 
 #define WIN32_LEAN_AND_MEAN
 #define NOGDI
-#include <direct.h>
 #include <windows.h>
 #include <io.h>
 #include <psapi.h>
 #include <stdlib.h>
 
 #include "sanitizer_common.h"
 #include "sanitizer_file.h"
 #include "sanitizer_libc.h"

 }
 
 u64 MonotonicNanoTime() { return NanoTime(); }
 
 void Abort() {
   internal__exit(3);
 }
 
-bool CreateDir(const char *pathname) { return _mkdir(pathname) == 0; }
+bool CreateDir(const char *pathname) {
+  return CreateDirectoryA(pathname, nullptr) != 0;
+}
 
 #if !SANITIZER_GO
 // Read the file to extract the ImageBase field from the PE header. If ASLR is
 // disabled and this virtual address is available, the loader will typically
 // load the image at this address. Therefore, we call it the preferred base. Any
 // addresses in the DWARF typically assume that the object has been loaded at
 // this address.
 static uptr GetPreferredBase(const char *modname, char *buf, size_t buf_size) {