Index: clang/include/clang/Basic/Builtins.def =================================================================== --- clang/include/clang/Basic/Builtins.def +++ clang/include/clang/Basic/Builtins.def @@ -646,6 +646,7 @@ BUILTIN(__builtin_elementwise_abs, "v.", "nct") BUILTIN(__builtin_elementwise_max, "v.", "nct") BUILTIN(__builtin_elementwise_min, "v.", "nct") +BUILTIN(__builtin_elementwise_ceil, "v.", "nct") BUILTIN(__builtin_reduce_max, "v.", "nct") BUILTIN(__builtin_reduce_min, "v.", "nct") Index: clang/include/clang/Basic/DiagnosticSemaKinds.td =================================================================== --- clang/include/clang/Basic/DiagnosticSemaKinds.td +++ clang/include/clang/Basic/DiagnosticSemaKinds.td @@ -11334,6 +11334,12 @@ "pointer to a valid matrix element type|" "signed integer or floating point type|vector type}1 (was %2)">; +def err_builtin_float_invalid_arg_type: Error < + "%ordinal0 argument must be a " + "%select{vector or floating point type|matrix|" + "pointer to a valid matrix element type|" + "floating point type|vector type}1 (was %2)">; + def err_builtin_matrix_disabled: Error< "matrix types extension is disabled. Pass -fenable-matrix to enable it">; def err_matrix_index_not_integer: Error< Index: clang/include/clang/Sema/Sema.h =================================================================== --- clang/include/clang/Sema/Sema.h +++ clang/include/clang/Sema/Sema.h @@ -12762,6 +12762,8 @@ bool SemaBuiltinElementwiseMath(CallExpr *TheCall); bool SemaBuiltinElementwiseMathOneArg(CallExpr *TheCall); bool SemaBuiltinReduceMath(CallExpr *TheCall); + bool SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall); + bool SemaBuiltinElementwiseMathNotUnsignedArg(CallExpr *TheCall); // Matrix builtin handling. ExprResult SemaBuiltinMatrixTranspose(CallExpr *TheCall, Index: clang/lib/CodeGen/CGBuiltin.cpp =================================================================== --- clang/lib/CodeGen/CGBuiltin.cpp +++ clang/lib/CodeGen/CGBuiltin.cpp @@ -3112,6 +3112,14 @@ "elt.abs"); return RValue::get(Result); } + + case Builtin::BI__builtin_elementwise_ceil: { + Value *Op0 = EmitScalarExpr(E->getArg(0)); + Value *Result = Builder.CreateUnaryIntrinsic(llvm::Intrinsic::ceil, Op0, + nullptr, "elt.ceil"); + return RValue::get(Result); + } + case Builtin::BI__builtin_elementwise_max: { Value *Op0 = EmitScalarExpr(E->getArg(0)); Value *Op1 = EmitScalarExpr(E->getArg(1)); Index: clang/lib/Sema/SemaChecking.cpp =================================================================== --- clang/lib/Sema/SemaChecking.cpp +++ clang/lib/Sema/SemaChecking.cpp @@ -2099,9 +2099,14 @@ } case Builtin::BI__builtin_elementwise_abs: - if (SemaBuiltinElementwiseMathOneArg(TheCall)) + if (SemaBuiltinElementwiseMathNotUnsignedArg(TheCall)) return ExprError(); break; + case Builtin::BI__builtin_elementwise_ceil: + if (SemaBuiltinElementwiseMathFloatArg(TheCall)) + return ExprError(); + break; + case Builtin::BI__builtin_elementwise_min: case Builtin::BI__builtin_elementwise_max: if (SemaBuiltinElementwiseMath(TheCall)) @@ -16702,9 +16707,22 @@ if (checkMathBuiltinElementType(*this, ArgLoc, TyA)) return true; + return false; +} + +bool Sema::SemaBuiltinElementwiseMathNotUnsignedArg(CallExpr *TheCall) { + if (SemaBuiltinElementwiseMathOneArg(TheCall)) + return true; + + ExprResult A = UsualUnaryConversions(TheCall->getArg(0)); + QualType TyA = A.get()->getType(); + + SourceLocation ArgLoc = TheCall->getArg(0)->getBeginLoc(); QualType EltTy = TyA; - if (auto *VecTy = EltTy->getAs()) + + if (auto *VecTy = EltTy->getAs()) { EltTy = VecTy->getElementType(); + } if (EltTy->isUnsignedIntegerType()) return Diag(ArgLoc, diag::err_builtin_invalid_arg_type) << 1 << /*signed integer or float ty*/ 3 << TyA; @@ -16713,6 +16731,26 @@ return false; } +bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) { + if (SemaBuiltinElementwiseMathOneArg(TheCall)) + return true; + + ExprResult A = UsualUnaryConversions(TheCall->getArg(0)); + QualType TyA = A.get()->getType(); + + SourceLocation ArgLoc = TheCall->getArg(0)->getBeginLoc(); + QualType EltTy = TyA; + + if (auto *VecTy = EltTy->getAs()) + EltTy = VecTy->getElementType(); + if (EltTy->isUnsignedIntegerType() || EltTy->isIntegerType()) + return Diag(ArgLoc, diag::err_builtin_float_invalid_arg_type) + << 1 << /*float ty*/ 3 << TyA; + + TheCall->setType(TyA); + return false; +} + bool Sema::SemaBuiltinElementwiseMath(CallExpr *TheCall) { if (checkArgCount(*this, TheCall, 2)) return true; Index: clang/test/CodeGen/builtins-elementwise-math.c =================================================================== --- clang/test/CodeGen/builtins-elementwise-math.c +++ clang/test/CodeGen/builtins-elementwise-math.c @@ -189,3 +189,20 @@ // CHECK-NEXT: call i32 @llvm.smin.i32(i32 [[IAS1]], i32 [[B]]) int_as_one = __builtin_elementwise_min(int_as_one, b); } + +void test_builtin_elementwise_ceil(float f1, float f2, double d1, double d2, + float4 vf1, float4 vf2, si8 vi1, si8 vi2, + long long int i1, long long int i2, short si) { + // CHECK-LABEL: define void @test_builtin_elementwise_ceil( + // CHECK: [[F1:%.+]] = load float, float* %f1.addr, align 4 + // CHECK-NEXT: call float @llvm.ceil.f32(float [[F1]]) + f2 = __builtin_elementwise_ceil(f1); + + // CHECK: [[D1:%.+]] = load double, double* %d1.addr, align 8 + // CHECK-NEXT: call double @llvm.ceil.f64(double [[D1]]) + d2 = __builtin_elementwise_ceil(d1); + + // CHECK: [[VF1:%.+]] = load <4 x float>, <4 x float>* %vf1.addr, align 16 + // CHECK-NEXT: call <4 x float> @llvm.ceil.v4f32(<4 x float> [[VF1]]) + vf2 = __builtin_elementwise_ceil(vf1); +} Index: clang/test/Sema/builtins-elementwise-math.c =================================================================== --- clang/test/Sema/builtins-elementwise-math.c +++ clang/test/Sema/builtins-elementwise-math.c @@ -135,3 +135,24 @@ c1 = __builtin_elementwise_min(c1, c2); // expected-error@-1 {{1st argument must be a vector, integer or floating point type (was '_Complex float')}} } + +void test_builtin_elementwise_ceil(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) { + + struct Foo s = __builtin_elementwise_ceil(f); + // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}} + + i = __builtin_elementwise_ceil(); + // expected-error@-1 {{too few arguments to function call, expected 1, have 0}} + + i = __builtin_elementwise_ceil(i); + // expected-error@-1 {{1st argument must be a floating point type (was 'int')}} + + i = __builtin_elementwise_ceil(f, f); + // expected-error@-1 {{too many arguments to function call, expected 1, have 2}} + + u = __builtin_elementwise_ceil(u); + // expected-error@-1 {{1st argument must be a floating point type (was 'unsigned int')}} + + uv = __builtin_elementwise_ceil(uv); + // expected-error@-1 {{1st argument must be a floating point type (was 'unsigned4' (vector of 4 'unsigned int' values))}} +} Index: clang/test/SemaCXX/builtins-elementwise-math.cpp =================================================================== --- clang/test/SemaCXX/builtins-elementwise-math.cpp +++ clang/test/SemaCXX/builtins-elementwise-math.cpp @@ -36,3 +36,10 @@ static_assert(!is_const::value); static_assert(!is_const::value); } + +void test_builtin_elementwise_ceil() { + const float a = 42.0; + float b = 42.3; + static_assert(!is_const::value); + static_assert(!is_const::value); +}