Page MenuHomePhabricator

File Reorganization changes
Needs ReviewPublic

Authored by raramakr on Nov 23 2021, 10:37 PM.

Details

Summary

ROCM file reorganization feature(SWDEV-29145 )

  • Device library path moved to /opt/rocm/share
  • External module header file access using <component_name/header.h>
  • Hip is installed in /opt/rocm
  • Hsa header files moved to /opt/rocm/include/hsa/
  • Hip cmake file moved to /opt/rocm/lib/cmake/hip

Diff Detail

Event Timeline

raramakr created this revision.Nov 23 2021, 10:37 PM
raramakr requested review of this revision.Nov 23 2021, 10:37 PM
Herald added projects: Restricted Project, Restricted Project, Restricted Project. · View Herald Transcript
mehdi_amini added inline comments.Nov 23 2021, 10:38 PM
mlir/lib/ExecutionEngine/CMakeLists.txt
153

Is MLIR really coupled to Clang here? That seems suspicious to me.

mehdi_amini added inline comments.Nov 23 2021, 10:39 PM
mlir/lib/ExecutionEngine/CMakeLists.txt
153

In particular, this makes MLIR sensitive to the version actually installed on the machine, which is independent from whatever clang is in the repo. This seems undesirable, what am I missing here?

could you please include a complete diff context in the patch? You can do that by using git diff -U9999

mlir/lib/ExecutionEngine/CMakeLists.txt
153

Probably it is not depending on clang, but depending on HIP cmake file to get HIP package to be able to use HIP header and library files for kernel launching API.

To be compatible with all ROCm releases, probably CMAKE_MODULE_PATH should also include the HIP cmake path for both old and new ROCm releases.