Page MenuHomePhabricator

[mlir] Use ThreadPool::wait instead of waiting for Futures (NFC).
AbandonedPublic

Authored by fhahn on Mon, Nov 22, 4:08 AM.

Details

Summary

ThreadPool::wait waits until all queued tasks have finished. There is no
need for ThreadPool users to keep track of the returned futures, if all
they want to do is wait until all tasks have been completed.

Diff Detail

Event Timeline

fhahn created this revision.Mon, Nov 22, 4:08 AM
fhahn requested review of this revision.Mon, Nov 22, 4:08 AM

I'm not sure this is equivalent: I think that threadPool.wait(); will block on tasks submitted by other threads concurrently

fhahn abandoned this revision.Mon, Nov 22, 12:04 PM

I'm not sure this is equivalent: I think that threadPool.wait(); will block on tasks submitted by other threads concurrently

yeah I missed that this uses a shared thread pool!