diff --git a/clang-tools-extra/clangd/IncludeCleaner.cpp b/clang-tools-extra/clangd/IncludeCleaner.cpp --- a/clang-tools-extra/clangd/IncludeCleaner.cpp +++ b/clang-tools-extra/clangd/IncludeCleaner.cpp @@ -13,6 +13,7 @@ #include "SourceCode.h" #include "support/Logger.h" #include "support/Trace.h" +#include "clang/AST/ExprCXX.h" #include "clang/AST/RecursiveASTVisitor.h" #include "clang/Basic/SourceLocation.h" #include "clang/Lex/HeaderSearch.h" @@ -104,6 +105,14 @@ return true; } + // Some expressions might be not resolved yet due to ADL: conservatively mark + // all resolution candidates as used. + bool VisitOverloadExpr(OverloadExpr *E) { + for (const auto *ResolutionDecl : E->decls()) + add(ResolutionDecl); + return true; + } + private: using Base = RecursiveASTVisitor; diff --git a/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp b/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp --- a/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp +++ b/clang-tools-extra/clangd/unittests/IncludeCleanerTests.cpp @@ -97,6 +97,10 @@ "inline void ^foo() {}", "void bar() { foo(); }", }, + { + "template void ^foo(T &&F) {}", + "template void bar() { foo([](){}); }", + }, // Static function { "struct ^X { static bool ^foo(); }; bool X::^foo() {}",