Page MenuHomePhabricator

Add jstopinfo support to llgs
ClosedPublic

Authored by labath on Jul 22 2015, 7:11 AM.

Details

Summary

This adds support for jstopinfo field of stop-reply packets. This field enables us to avoid
querying full thread stop data on most stops (see r242593 for more details).

Event Timeline

labath updated this revision to Diff 30348.Jul 22 2015, 7:11 AM
labath retitled this revision from to Add jstopinfo support to llgs.
labath updated this object.
labath added reviewers: ovyalov, clayborg.
labath added a subscriber: lldb-commits.
clayborg accepted this revision.Jul 22 2015, 10:31 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Jul 22 2015, 10:31 AM
ovyalov accepted this revision.Jul 22 2015, 10:59 AM
ovyalov edited edge metadata.
ovyalov added inline comments.
source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
720 ↗(On Diff #30348)

Nit: if (thread_index > 0)? In this case no to acquire NativeProcessProtocol::m_threads_mutex

723 ↗(On Diff #30348)

Could you check for threads_info_sp != nullptr?

This revision was automatically updated to reflect the committed changes.
labath marked 2 inline comments as done.