This is an archive of the discontinued LLVM Phabricator instance.

Differential D113895

[NFC][clangd] fix llvm-namespace-comment finding
ClosedPublic

Authored by kuhnel on Nov 15 2021, 7:10 AM.

Details

Reviewers
kadircet
Commits
rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding
Summary

Fixing the clang-tidy finding.

Diff Detail

Event Timeline

kuhnel created this revision.Nov 15 2021, 7:10 AM
Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman. · View Herald TranscriptNov 15 2021, 7:10 AM
Harbormaster completed remote builds in B134248: Diff 387249.Nov 15 2021, 7:28 AM
kuhnel published this revision for review.Nov 15 2021, 8:07 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2021, 8:07 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
kadircet accepted this revision.Nov 16 2021, 6:33 AM
This revision is now accepted and ready to land.Nov 16 2021, 6:33 AM
Closed by commit rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding (authored by kuhnel). · Explain WhyNov 16 2021, 7:11 AM
This revision was automatically updated to reflect the committed changes.
kuhnel added a commit: rG274f12a44c60: [NFC][clangd] fix llvm-namespace-comment finding.

Revision Contents

PathSize
clang-tools-extra/
clangd/
xpc/
2 lines

Diff 387630

clang-tools-extra/clangd/xpc/XPCTransport.cpp

Show First 20 Lines • Show All 41 Lines • ▼ Show 20 LinesError decodeError(const json::Object &O) {
if (auto Code = O.getInteger("code")) if (auto Code = O.getInteger("code"))
return make_error<LSPError>(std::move(Msg), ErrorCode(*Code)); return make_error<LSPError>(std::move(Msg), ErrorCode(*Code));
return error("{0}", Msg); return error("{0}", Msg);
} }
// C "closure" for XPCTransport::loop() method // C "closure" for XPCTransport::loop() method
namespace xpcClosure { namespace xpcClosure {
void connection_handler(xpc_connection_t clientConnection); void connection_handler(xpc_connection_t clientConnection);
} } // namespace xpcClosure
class XPCTransport : public Transport { class XPCTransport : public Transport {
public: public:
XPCTransport() {} XPCTransport() {}
void notify(StringRef Method, json::Value Params) override { void notify(StringRef Method, json::Value Params) override {
sendMessage(json::Object{ sendMessage(json::Object{
{"jsonrpc", "2.0"}, {"jsonrpc", "2.0"},
▲ Show 20 Lines • Show All 159 Lines • Show Last 20 Lines