diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp --- a/clang-tools-extra/clangd/ClangdLSPServer.cpp +++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp @@ -929,8 +929,7 @@ adjustSymbolKinds(*Items, SupportedSymbolKinds); if (SupportsHierarchicalDocumentSymbol) return Reply(std::move(*Items)); - else - return Reply(flattenSymbolHierarchy(*Items, FileURI)); + return Reply(flattenSymbolHierarchy(*Items, FileURI)); }); } diff --git a/clang-tools-extra/clangd/FuzzyMatch.cpp b/clang-tools-extra/clangd/FuzzyMatch.cpp --- a/clang-tools-extra/clangd/FuzzyMatch.cpp +++ b/clang-tools-extra/clangd/FuzzyMatch.cpp @@ -320,8 +320,9 @@ if (!WordContainsPattern) { OS << "Substring check failed.\n"; return Result; - } else if (isAwful(std::max(Scores[PatN][WordN][Match].Score, - Scores[PatN][WordN][Miss].Score))) { + } + if (isAwful(std::max(Scores[PatN][WordN][Match].Score, + Scores[PatN][WordN][Miss].Score))) { OS << "Substring check passed, but all matches are forbidden\n"; } if (!(PatTypeSet & 1 << Upper)) diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -74,7 +74,7 @@ // - Classes, categories, and protocols: "MyClass(Category)" if (const ObjCMethodDecl *MD = dyn_cast(DC)) return printObjCMethod(*MD); - else if (const ObjCContainerDecl *CD = dyn_cast(DC)) + if (const ObjCContainerDecl *CD = dyn_cast(DC)) return printObjCContainer(*CD); auto GetName = [](const TypeDecl *D) { diff --git a/clang-tools-extra/clangd/JSONTransport.cpp b/clang-tools-extra/clangd/JSONTransport.cpp --- a/clang-tools-extra/clangd/JSONTransport.cpp +++ b/clang-tools-extra/clangd/JSONTransport.cpp @@ -194,8 +194,7 @@ if (ID) return Handler.onCall(*Method, std::move(Params), std::move(*ID)); - else - return Handler.onNotify(*Method, std::move(Params)); + return Handler.onNotify(*Method, std::move(Params)); } // Tries to read a line up to and including \n. @@ -254,7 +253,8 @@ } llvm::getAsUnsignedInteger(LineRef.trim(), 0, ContentLength); continue; - } else if (!LineRef.trim().empty()) { + } + if (!LineRef.trim().empty()) { // It's another header, ignore it. continue; } else { @@ -279,9 +279,8 @@ JSON.resize(ContentLength); for (size_t Pos = 0, Read; Pos < ContentLength; Pos += Read) { // Handle EINTR which is sent when a debugger attaches on some platforms. - Read = retryAfterSignalUnlessShutdown(0, [&]{ - return std::fread(&JSON[Pos], 1, ContentLength - Pos, In); - }); + Read = retryAfterSignalUnlessShutdown( + 0, [&] { return std::fread(&JSON[Pos], 1, ContentLength - Pos, In); }); if (Read == 0) { elog("Input was aborted. Read only {0} bytes of expected {1}.", Pos, ContentLength); diff --git a/clang-tools-extra/clangd/PathMapping.cpp b/clang-tools-extra/clangd/PathMapping.cpp --- a/clang-tools-extra/clangd/PathMapping.cpp +++ b/clang-tools-extra/clangd/PathMapping.cpp @@ -40,8 +40,7 @@ llvm::StringRef Body = Uri->body(); if (Body.consume_front(From) && (Body.empty() || Body.front() == '/')) { std::string MappedBody = (To + Body).str(); - return URI(Uri->scheme(), Uri->authority(), MappedBody) - .toString(); + return URI(Uri->scheme(), Uri->authority(), MappedBody).toString(); } } return llvm::None; @@ -151,7 +150,8 @@ namespace path = llvm::sys::path; if (path::is_absolute(Path, path::Style::posix)) { return std::string(Path); - } else if (path::is_absolute(Path, path::Style::windows)) { + } + if (path::is_absolute(Path, path::Style::windows)) { std::string Converted = path::convert_to_slash(Path, path::Style::windows); if (Converted.front() != '/') Converted = "/" + Converted; diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp --- a/clang-tools-extra/clangd/Protocol.cpp +++ b/clang-tools-extra/clangd/Protocol.cpp @@ -695,7 +695,8 @@ if (ArgsArray->size() > 1) { P.field("arguments").report("Command should have 0 or 1 argument"); return false; - } else if (ArgsArray->size() == 1) { + } + if (ArgsArray->size() == 1) { R.argument = ArgsArray->front(); } return true; diff --git a/clang-tools-extra/clangd/Selection.cpp b/clang-tools-extra/clangd/Selection.cpp --- a/clang-tools-extra/clangd/Selection.cpp +++ b/clang-tools-extra/clangd/Selection.cpp @@ -346,9 +346,8 @@ SM.getTopMacroCallerLoc(Batch.back().location()); return testTokenRange(SM.getFileOffset(ArgStart), SM.getFileOffset(ArgEnd)); - } else { - /* fall through and treat as part of the macro body */ } + /* fall through and treat as part of the macro body */ } // Handle tokens produced by non-argument macro expansion. @@ -357,8 +356,7 @@ if (Expansion.first == SelFile) // FIXME: also check ( and ) for function-like macros? return testToken(Expansion.second); - else - return NoTokens; + return NoTokens; } // Is the closed token range [Begin, End] selected? diff --git a/clang-tools-extra/clangd/TUScheduler.cpp b/clang-tools-extra/clangd/TUScheduler.cpp --- a/clang-tools-extra/clangd/TUScheduler.cpp +++ b/clang-tools-extra/clangd/TUScheduler.cpp @@ -1282,8 +1282,8 @@ if (Done) { if (Requests.empty()) return; - else // Even though Done is set, finish pending requests. - break; // However, skip delays to shutdown fast. + // Even though Done is set, finish pending requests. + break; // However, skip delays to shutdown fast. } // Tracing: we have a next request, attribute this sleep to it. diff --git a/clang-tools-extra/clangd/XRefs.cpp b/clang-tools-extra/clangd/XRefs.cpp --- a/clang-tools-extra/clangd/XRefs.cpp +++ b/clang-tools-extra/clangd/XRefs.cpp @@ -401,8 +401,8 @@ } } // Special case: void foo() ^override: jump to the overridden method. - if (NodeKind.isSame(ASTNodeKind::getFromNodeKind()) || - NodeKind.isSame(ASTNodeKind::getFromNodeKind())) { + if (NodeKind.isSame(ASTNodeKind::getFromNodeKind()) || + NodeKind.isSame(ASTNodeKind::getFromNodeKind())) { // We may be overridding multiple methods - offer them all. for (const NamedDecl *ND : CMD->overridden_methods()) AddResultDecl(ND); @@ -826,10 +826,9 @@ log("Found definition heuristically using nearby identifier {0}", NearbyIdent->text(SM)); return ASTResults; - } else { - vlog("No definition found using nearby identifier {0} at {1}", - Word->Text, Word->Location.printToString(SM)); } + vlog("No definition found using nearby identifier {0} at {1}", Word->Text, + Word->Location.printToString(SM)); } // No nearby word, or it didn't refer to anything either. Try the index. auto TextualResults = @@ -1430,28 +1429,27 @@ // Add decl/def of overridding methods. if (Index && Results.References.size() <= Limit && !OverriddenBy.Subjects.empty()) - Index->relations( - OverriddenBy, [&](const SymbolID &Subject, const Symbol &Object) { - const auto LSPLocDecl = - toLSPLocation(Object.CanonicalDeclaration, *MainFilePath); - const auto LSPLocDef = - toLSPLocation(Object.Definition, *MainFilePath); - if (LSPLocDecl && LSPLocDecl != LSPLocDef) { - ReferencesResult::Reference Result; - Result.Loc = std::move(*LSPLocDecl); - Result.Attributes = - ReferencesResult::Declaration | ReferencesResult::Override; - Results.References.push_back(std::move(Result)); - } - if (LSPLocDef) { - ReferencesResult::Reference Result; - Result.Loc = std::move(*LSPLocDef); - Result.Attributes = ReferencesResult::Declaration | - ReferencesResult::Definition | - ReferencesResult::Override; - Results.References.push_back(std::move(Result)); - } - }); + Index->relations(OverriddenBy, [&](const SymbolID &Subject, + const Symbol &Object) { + const auto LSPLocDecl = + toLSPLocation(Object.CanonicalDeclaration, *MainFilePath); + const auto LSPLocDef = toLSPLocation(Object.Definition, *MainFilePath); + if (LSPLocDecl && LSPLocDecl != LSPLocDef) { + ReferencesResult::Reference Result; + Result.Loc = std::move(*LSPLocDecl); + Result.Attributes = + ReferencesResult::Declaration | ReferencesResult::Override; + Results.References.push_back(std::move(Result)); + } + if (LSPLocDef) { + ReferencesResult::Reference Result; + Result.Loc = std::move(*LSPLocDef); + Result.Attributes = ReferencesResult::Declaration | + ReferencesResult::Definition | + ReferencesResult::Override; + Results.References.push_back(std::move(Result)); + } + }); if (Index && Results.References.size() <= Limit) { for (const Decl *D : Decls) { diff --git a/clang-tools-extra/clangd/index/Serialization.cpp b/clang-tools-extra/clangd/index/Serialization.cpp --- a/clang-tools-extra/clangd/index/Serialization.cpp +++ b/clang-tools-extra/clangd/index/Serialization.cpp @@ -687,7 +687,8 @@ llvm::Expected readIndexFile(llvm::StringRef Data) { if (Data.startswith("RIFF")) { return readRIFF(Data); - } else if (auto YAMLContents = readYAML(Data)) { + } + if (auto YAMLContents = readYAML(Data)) { return std::move(*YAMLContents); } else { return error("Not a RIFF file and failed to parse as YAML: {0}", diff --git a/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp b/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp --- a/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp +++ b/clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp @@ -250,7 +250,8 @@ for (; Node->Parent; Node = Node->Parent) { if (Node->ASTNode.get()) { continue; - } else if (auto *T = Node->ASTNode.get()) { + } + if (auto *T = Node->ASTNode.get()) { if (T->getAs()) { break; } else if (Node->Parent->ASTNode.get() || diff --git a/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp b/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp --- a/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp +++ b/clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp @@ -223,8 +223,7 @@ while (const auto *CS = llvm::dyn_cast(Last)) { if (CS->body_empty()) return false; - else - Last = CS->body_back(); + Last = CS->body_back(); } return llvm::isa(Last); }