diff --git a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp --- a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp +++ b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp @@ -791,6 +791,27 @@ EXPECT_THAT(*TU.build().getDiagnostics(), IsEmpty()); } +TEST(DiagnosticsTest, ConstrainedImplicitDeductionGuides) { + Annotations Header(R"cpp( +template struct S; + +template struct S { + template requires(false) S(U); + template requires(true) S(U); +}; + +template S(T) -> S<>; + )cpp"); + Annotations Main(R"cpp( + #include "a.h" + S s(0); + )cpp"); + TestTU TU = TestTU::withCode(Main.code()); + TU.ExtraArgs.push_back("-std=c++20"); + TU.AdditionalFiles = {{"a.h", std::string(Header.code())}}; + EXPECT_THAT(*TU.build().getDiagnostics(), IsEmpty()); +} + TEST(ClangdTest, MSAsm) { // Parsing MS assembly tries to use the target MCAsmInfo, which we don't link. // We used to crash here. Now clang emits a diagnostic, which we filter out. diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp --- a/clang/lib/Sema/SemaTemplate.cpp +++ b/clang/lib/Sema/SemaTemplate.cpp @@ -2184,10 +2184,24 @@ SubstArgs.push_back(SemaRef.Context.getCanonicalTemplateArgument( SemaRef.Context.getInjectedTemplateArg(NewParam))); } + + // Substitute new template parameters into requires-clause if present. + Expr *RequiresClause = nullptr; + if (Expr *InnerRC = InnerParams->getRequiresClause()) { + MultiLevelTemplateArgumentList Args; + Args.setKind(TemplateSubstitutionKind::Rewrite); + Args.addOuterTemplateArguments(SubstArgs); + Args.addOuterRetainedLevel(); + ExprResult E = SemaRef.SubstExpr(InnerRC, Args); + if (E.isInvalid()) + return nullptr; + RequiresClause = E.getAs(); + } + TemplateParams = TemplateParameterList::Create( SemaRef.Context, InnerParams->getTemplateLoc(), InnerParams->getLAngleLoc(), AllParams, InnerParams->getRAngleLoc(), - /*FIXME: RequiresClause*/ nullptr); + RequiresClause); } // If we built a new template-parameter-list, track that we need to diff --git a/clang/test/SemaTemplate/deduction-guide.cpp b/clang/test/SemaTemplate/deduction-guide.cpp --- a/clang/test/SemaTemplate/deduction-guide.cpp +++ b/clang/test/SemaTemplate/deduction-guide.cpp @@ -206,3 +206,39 @@ // CHECK: `-TemplateArgument expr // CHECK-NOT: Subst // CHECK: `-DeclRefExpr {{.*}} 'int' NonTypeTemplateParm [[M2]] 'M2' 'int' + +template struct F; + +template struct F { + template + requires(false) F(U); + template + requires(true) F(U); +}; + +template F(T) -> F<>; + +F s(0); + +// CHECK-LABEL: Dumping : +// CHECK: FunctionTemplateDecl +// CHECK: |-NonTypeTemplateParmDecl {{.*}} 'char' depth 0 index 0 +// CHECK: `-TemplateArgument expr +// CHECK: | |-inherited from NonTypeTemplateParm {{.*}} '' 'char' +// CHECK: | `-ConstantExpr {{.*}} 'char' +// CHECK: | |-value: Int 120 +// CHECK: | `-CharacterLiteral {{.*}} 'char' 120 +// CHECK: |-TemplateTypeParmDecl {{.*}} typename depth 0 index 1 U +// CHECK: |-ParenExpr {{.*}} 'bool' +// CHECK: | `-CXXBoolLiteralExpr {{.*}} 'bool' false +// CHECK: |-CXXDeductionGuideDecl {{.*}} implicit 'auto (type-parameter-0-1) -> F<>' +// CHECK: | `-ParmVarDecl {{.*}} 'type-parameter-0-1' +// CHECK: `-CXXDeductionGuideDecl {{.*}} implicit 'auto (int) -> F<'x'>' +// CHECK: |-TemplateArgument integral 120 +// CHECK: |-TemplateArgument type 'int' +// CHECK: | `-BuiltinType {{.*}} 'int' +// CHECK: `-ParmVarDecl {{.*}} 'int':'int' +// CHECK: FunctionProtoType {{.*}} 'auto (type-parameter-0-1) -> F<>' dependent trailing_return cdecl +// CHECK: |-InjectedClassNameType {{.*}} 'F<>' dependent +// CHECK: | `-CXXRecord {{.*}} 'F' +// CHECK: `-TemplateTypeParmType {{.*}} 'type-parameter-0-1' dependent depth 0 index 1