diff --git a/clang/lib/AST/DeclCXX.cpp b/clang/lib/AST/DeclCXX.cpp --- a/clang/lib/AST/DeclCXX.cpp +++ b/clang/lib/AST/DeclCXX.cpp @@ -178,6 +178,8 @@ SmallVector WorkList = {StartRD}; while (!WorkList.empty()) { const CXXRecordDecl *RD = WorkList.pop_back_val(); + if (RD->getTypeForDecl()->isDependentType()) + continue; for (const CXXBaseSpecifier &BaseSpec : RD->bases()) { if (const CXXRecordDecl *B = BaseSpec.getType()->getAsCXXRecordDecl()) { if (!SeenBaseTypes.insert(B).second) diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -2729,6 +2729,8 @@ KnownBase = Bases[idx]; Bases[NumGoodBases++] = Bases[idx]; + if (NewBaseType->isDependentType()) + continue; // Note this base's direct & indirect bases, if there could be ambiguity. if (Bases.size() > 1) NoteIndirectBases(Context, IndirectBaseTypes, NewBaseType); diff --git a/clang/test/SemaCXX/base-class-ambiguity-check.cpp b/clang/test/SemaCXX/base-class-ambiguity-check.cpp --- a/clang/test/SemaCXX/base-class-ambiguity-check.cpp +++ b/clang/test/SemaCXX/base-class-ambiguity-check.cpp @@ -1,5 +1,4 @@ // RUN: %clang_cc1 -fsyntax-only -verify %s -// expected-no-diagnostics template class Foo { struct Base : T {}; @@ -7,3 +6,14 @@ // Test that this code no longer causes a crash in Sema. rdar://23291875 struct Derived : Base, T {}; }; + + +template struct Foo2 { + struct Base1; // expected-note{{member is declared here}} + struct Base2; // expected-note{{member is declared here}} + // Should not crash on an incomplete-type and dependent base specifier. + struct Derived : Base1, Base2 {}; // expected-error {{implicit instantiation of undefined member 'Foo2::Base1'}} \ + expected-error {{implicit instantiation of undefined member 'Foo2::Base2'}} +}; + +Foo2::Derived a; // expected-note{{in instantiation of member class}} diff --git a/clang/test/SemaCXX/ms-interface.cpp b/clang/test/SemaCXX/ms-interface.cpp --- a/clang/test/SemaCXX/ms-interface.cpp +++ b/clang/test/SemaCXX/ms-interface.cpp @@ -106,3 +106,10 @@ static_assert(!__is_interface_class(IUnknown), "oops"); static_assert(!__is_interface_class(IFaceStruct), "oops"); static_assert(!__is_interface_class(IFaceInheritsStruct), "oops"); + +template +class TemplateContext { + class Base; + // Should not crash on an incomplete-type and dependent base specifier. + __interface Foo : Base {}; +};