This is an archive of the discontinued LLVM Phabricator instance.

Differential D113431

[clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen
ClosedPublic

Authored by ibookstein on Nov 8 2021, 1:05 PM.

Details

Reviewers
erichkeane
Commits
rGce91540beeff: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen
Summary

Signed-off-by: Itay Bookstein <ibookstein@gmail.com>

Diff Detail

Event Timeline

ibookstein created this revision.Nov 8 2021, 1:05 PM
Harbormaster completed remote builds in B133103: Diff 385610.Nov 8 2021, 1:06 PM
ibookstein added a parent revision: D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers.Nov 8 2021, 1:06 PM
ibookstein published this revision for review.Nov 8 2021, 1:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 8 2021, 1:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
ibookstein removed a parent revision: D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers.Nov 8 2021, 1:13 PM
ibookstein added a child revision: D112868: [CodeGen] Diagnose and reject non-function ifunc resolvers.
ibookstein added a parent revision: D113504: [clang][test][NFC] clang-format attr-ifunc.c test.Nov 9 2021, 12:07 PM
ibookstein updated this revision to Diff 385923.Nov 9 2021, 12:08 PM

add parent clang-format commit to pass CI

ibookstein added a reviewer: erichkeane.Nov 9 2021, 12:10 PM
erichkeane added a comment.Nov 9 2021, 12:11 PM

I've got no problem with this, but it could just as easily have happened in the other review. Is there a reason not to?

Harbormaster completed remote builds in B133327: Diff 385923.Nov 9 2021, 12:39 PM
ibookstein added a comment.Nov 9 2021, 1:37 PM

If you meant fusing the clang-format commit with this one, doing it in the same commit results in git no longer detecting the connection between them (similarity too low), so it loses the history. When searching I found a recommendation to avoid combining renames with modifications where git history matters, so I thought I might as well :)

erichkeane accepted this revision.Nov 9 2021, 1:38 PM
In D113431#3119716, @ibookstein wrote:

If you meant fusing the clang-format commit with this one, doing it in the same commit results in git no longer detecting the connection between them (similarity too low), so it loses the history. When searching I found a recommendation to avoid combining renames with modifications where git history matters, so I thought I might as well :)

I'd thought about it on the other review where it was questioned to be moved, but i don't care that much...

This revision is now accepted and ready to land.Nov 9 2021, 1:38 PM
ibookstein added a comment.Nov 9 2021, 1:49 PM

Right; well, thanks!

Closed by commit rGce91540beeff: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen (authored by ibookstein). · Explain WhyNov 9 2021, 1:51 PM
This revision was automatically updated to reflect the committed changes.
ibookstein added a commit: rGce91540beeff: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen.

Revision Contents

PathSize
clang/
test/
CodeGen/
Sema/
Sema/

Diff 385966

clang/test/CodeGen/attr-ifunc.c

  • This file was moved from clang/test/Sema/attr-ifunc.c.
The contents of this file were not changed.

clang/test/Sema/attr-ifunc.c

  • This file was moved to clang/test/CodeGen/attr-ifunc.c.