This is an archive of the discontinued LLVM Phabricator instance.

[clang-move] Fix unit tests with forward slash as separator on windows
ClosedPublic

Authored by mstorsjo on Nov 5 2021, 5:06 AM.

Diff Detail

Event Timeline

mstorsjo requested review of this revision.Nov 5 2021, 5:06 AM
mstorsjo created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2021, 5:06 AM
aaron.ballman accepted this revision.Nov 8 2021, 9:43 AM

LGTM aside from commenting nit.

clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp
234–235

Might as well remove this comment entirely? I don't think it adds any value, it looks like debug code that was left in by accident.

This revision is now accepted and ready to land.Nov 8 2021, 9:43 AM
mstorsjo added inline comments.Nov 8 2021, 12:19 PM
clang-tools-extra/unittests/clang-move/ClangMoveTests.cpp
234–235

Sure, I can remove it.

This revision was landed with ongoing or failed builds.Nov 8 2021, 12:22 PM
This revision was automatically updated to reflect the committed changes.