This is an archive of the discontinued LLVM Phabricator instance.

[Docs] Mention that compier-rt's check-all depend on clang
AbandonedPublic

Authored by xgupta on Nov 2 2021, 5:50 AM.

Details

Reviewers
dvyukov
delcypher
Summary

When we don't add clang to -DLLVM_ENABLE_PROJECTS an cmake error shows:

CMake Error at cmake/modules/AddLLVM.cmake:1814 (add_dependencies):

The dependency target "clang" of target "check-all" does not exist.

Call Stack (most recent call first):

CMakeLists.txt:1071 (add_lit_target)

CMake Error at cmake/modules/AddLLVM.cmake:1814 (add_dependencies):

The dependency target "clang-resource-headers" of target "check-all" does
not exist.

Call Stack (most recent call first):

CMakeLists.txt:1071 (add_lit_target)

Although build was succussful but when run chack-all an error occurs:

make[3]: *** No rule to make target 'projects/compiler-rt/lib/sanitizer_common/tests/clang', needed by 'projects/compiler-rt/lib/sanitizer_common/tests/Sanitizer-x86_64-Test-Nolibc'. Stop.

Diff Detail

Event Timeline

xgupta created this revision.Nov 2 2021, 5:50 AM
xgupta requested review of this revision.Nov 2 2021, 5:50 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 5:50 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

ping @dvyukov, Does this patch need a review or It was my mistake in configure step.

The page looks outdated. It may need to be converted to .rst.
The cmake ../compiler-rt configuration seems like a not-recommended way for Clang. Maybe it is still used by GCC sanitizers.

For Clang, if -DLLVM_ENABLE_PROJECTS= -DLLVM_ENABLE_RUNTIMES=compiler-rt is used (clang not listed), it will fail early in CMake.

The page looks outdated. It may need to be converted to .rst.

Ok, Thanks for taking a look. I will send a patch for that on sunday. I think a few pages of clang are also written in .html in clang/www/ directory so they also need an update, will send a patch soon.

The cmake ../compiler-rt configuration seems like a not-recommended way for Clang. Maybe it is still used by GCC sanitizers.

For Clang, if -DLLVM_ENABLE_PROJECTS= -DLLVM_ENABLE_RUNTIMES=compiler-rt is used (clang not listed), it will fail early in CMake.

I will read the compiler-rt/CMakeLists.txt and rewrite what changes are needed in .rst file.

xgupta abandoned this revision.Dec 5 2021, 8:36 PM

Will do it later.