Page MenuHomePhabricator

[Attributor][FIX] Use right address space to avoid assertion
ClosedPublic

Authored by jdoerfert on Oct 26 2021, 8:08 AM.

Details

Summary

When we strip and accumulate constant offsets we need to pick the right
address space such that the offset APInt has the right bit width.

Diff Detail

Event Timeline

jdoerfert created this revision.Oct 26 2021, 8:08 AM
jdoerfert requested review of this revision.Oct 26 2021, 8:08 AM
Herald added a reviewer: baziotis. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
JonChesterfield accepted this revision.Oct 26 2021, 8:10 AM

LG, thanks. I haven't followed the opaque / typeless work, presumably there's some new API one is expected to call for them.

This revision is now accepted and ready to land.Oct 26 2021, 8:10 AM

Ping. If you land this, I can the land D112227 and confirm that it gets through the amdgpu buildbot.

arsenm added a subscriber: arsenm.Oct 27 2021, 6:13 AM
arsenm added inline comments.
llvm/lib/Transforms/IPO/AttributorAttributes.cpp
1227–1232

This is only using the type to get the address space, there's nothing bad going on here

This revision was landed with ongoing or failed builds.Oct 27 2021, 4:23 PM
This revision was automatically updated to reflect the committed changes.