This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Minor code improvement. Replacing simplifyOnce with simplifyOnceImpl.
ClosedPublic

Authored by dbakunevich on Oct 25 2021, 11:22 PM.

Details

Summary

While fixing the bug, it was discovered that the simplifyOnce function returns the value of the simplifyOnceImpl function. Therefore, it was decided to remove the simplifyOnce function and replace all its calls with simplifyOnceImpl.

Diff Detail

Event Timeline

dbakunevich created this revision.Oct 25 2021, 11:22 PM
dbakunevich requested review of this revision.Oct 25 2021, 11:22 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 11:22 PM
mkazantsev requested changes to this revision.Oct 25 2021, 11:23 PM
mkazantsev added inline comments.
llvm/lib/Transforms/Utils/SimplifyCFG.cpp
282

Do it vice versa: leave simplifyOnce and remove simplifyOnceImpl.

This revision now requires changes to proceed.Oct 25 2021, 11:23 PM
mkazantsev accepted this revision.Oct 25 2021, 11:38 PM
This revision is now accepted and ready to land.Oct 25 2021, 11:38 PM
This revision was landed with ongoing or failed builds.Oct 25 2021, 11:52 PM
This revision was automatically updated to reflect the committed changes.