diff --git a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp --- a/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp +++ b/llvm/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp @@ -1163,7 +1163,7 @@ // llvm::Value of the correct type (and still remain pure). // This will remove the need to add bitcasts. assert(Base->stripPointerCasts() == OldBase->stripPointerCasts() && - "Sanity -- findBaseOrBDV should be pure!"); + "findBaseOrBDV should be pure!"); #endif } Value *Base = BlockToValue[InBB]; @@ -1854,7 +1854,7 @@ // It receives iterator to the statepoint gc relocates and emits a store to the // assigned location (via allocaMap) for the each one of them. It adds the // visited values into the visitedLiveValues set, which we will later use them -// for sanity checking. +// for validation checking. static void insertRelocationStores(iterator_range GCRelocs, DenseMap &AllocaMap, @@ -2453,7 +2453,7 @@ SmallVectorImpl &ToUpdate, DefiningValueMapTy &DVCache) { #ifndef NDEBUG - // sanity check the input + // Validate the input std::set Uniqued; Uniqued.insert(ToUpdate.begin(), ToUpdate.end()); assert(Uniqued.size() == ToUpdate.size() && "no duplicates please!"); @@ -2619,9 +2619,9 @@ // we just grab that. llvm::append_range(Live, Info.StatepointToken->gc_args()); #ifndef NDEBUG - // Do some basic sanity checks on our liveness results before performing - // relocation. Relocation can and will turn mistakes in liveness results - // into non-sensical code which is must harder to debug. + // Do some basic validation checking on our liveness results before + // performing relocation. Relocation can and will turn mistakes in liveness + // results into non-sensical code which is must harder to debug. // TODO: It would be nice to test consistency as well assert(DT.isReachableFromEntry(Info.StatepointToken->getParent()) && "statepoint must be reachable or liveness is meaningless"); @@ -2640,7 +2640,7 @@ unique_unsorted(Live); #ifndef NDEBUG - // sanity check + // Validation check for (auto *Ptr : Live) assert(isHandledGCPointerType(Ptr->getType()) && "must be a gc pointer type"); @@ -3016,7 +3016,7 @@ #ifndef NDEBUG /// Check that the items in 'Live' dominate 'TI'. This is used as a basic -/// sanity check for the liveness computation. +/// validation check for the liveness computation. static void checkBasicSSA(DominatorTree &DT, SetVector &Live, Instruction *TI, bool TermOkay = false) { for (Value *V : Live) { @@ -3103,7 +3103,7 @@ } // while (!Worklist.empty()) #ifndef NDEBUG - // Sanity check our output against SSA properties. This helps catch any + // Verify our output against SSA properties. This helps catch any // missing kills during the above iteration. for (BasicBlock &BB : F) checkBasicSSA(DT, Data, BB); diff --git a/llvm/test/Transforms/RewriteStatepointsForGC/codegen-cond.ll b/llvm/test/Transforms/RewriteStatepointsForGC/codegen-cond.ll --- a/llvm/test/Transforms/RewriteStatepointsForGC/codegen-cond.ll +++ b/llvm/test/Transforms/RewriteStatepointsForGC/codegen-cond.ll @@ -50,7 +50,7 @@ ; CHECK-DAG: [ %p, %entry ] ; CHECK: %cond = icmp ; CHECK: br i1 %cond -; Sanity check that nothing bad happens if already last instruction +; Check that nothing bad happens if already last instruction ; before terminator br i1 %cond, label %taken, label %untaken