diff --git a/libcxx/cmake/caches/Generic-debug-iterators.cmake b/libcxx/cmake/caches/Generic-debug-iterators.cmake --- a/libcxx/cmake/caches/Generic-debug-iterators.cmake +++ b/libcxx/cmake/caches/Generic-debug-iterators.cmake @@ -1,2 +1,2 @@ -set(LIBCXX_TEST_PARAMS "debug_level=1" "additional_features=LIBCXX-DEBUG-FIXME" CACHE STRING "") +set(LIBCXX_TEST_PARAMS "debug_level=1" CACHE STRING "") set(LIBCXXABI_TEST_PARAMS "${LIBCXX_TEST_PARAMS}" CACHE STRING "") diff --git a/libcxx/utils/libcxx/test/params.py b/libcxx/utils/libcxx/test/params.py --- a/libcxx/utils/libcxx/test/params.py +++ b/libcxx/utils/libcxx/test/params.py @@ -123,10 +123,11 @@ Parameter(name='debug_level', choices=['', '0', '1'], type=str, default='', help="The debugging level to enable in the test suite.", - actions=lambda debugLevel: [] if debugLevel == '' else [ + actions=lambda debugLevel: [] if debugLevel == '' else filter(None, [ AddFeature('debug_level={}'.format(debugLevel)), - AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel)) - ]), + AddCompileFlag('-D_LIBCPP_DEBUG={}'.format(debugLevel)), + AddFeature('LIBCXX-DEBUG-FIXME') if debugLevel == '1' else None + ])), Parameter(name='use_sanitizer', choices=['', 'Address', 'Undefined', 'Memory', 'MemoryWithOrigins', 'Thread', 'DataFlow', 'Leaks'], type=str, default='', help="An optional sanitizer to enable when building and running the test suite.",