Page MenuHomePhabricator
Differential D111999

[libomptarget] Refactor DeviceRTL prior to AMDGPU bringup
ClosedPublic
Actions

Authored by JonChesterfield on Oct 18 2021, 8:13 AM.

Details

Reviewers
jdoerfert
tianshilei1992
Commits
rG7272982e1dfe: [libomptarget] Refactor DeviceRTL prior to AMDGPU bringup
Summary

Subset of D111993. Fix typos, rename read to load.

Diff Detail

Event Timeline

JonChesterfield created this revision.Oct 18 2021, 8:13 AM
Herald added subscribers: t-tye, tpr, dstuttard and 2 others. · View Herald TranscriptOct 18 2021, 8:13 AM
JonChesterfield requested review of this revision.Oct 18 2021, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 8:13 AM
Herald added subscribers: openmp-commits, sstefan1, wdng. · View Herald Transcript
Harbormaster completed remote builds in B129350: Diff 380406.Oct 18 2021, 8:32 AM
tianshilei1992 accepted this revision.Oct 18 2021, 5:06 PM
tianshilei1992 added a subscriber: tianshilei1992.

LGTM. It's not NFC because there are some function cleanup, function signature changes, etc.

This revision is now accepted and ready to land.Oct 18 2021, 5:06 PM
JonChesterfield retitled this revision from [libomptarget][nfc] Refactor DeviceRTL prior to AMDGPU bringup to [libomptarget] Refactor DeviceRTL prior to AMDGPU bringup.Oct 19 2021, 12:04 AM
This revision was landed with ongoing or failed builds.Oct 19 2021, 12:05 AM
Closed by commit rG7272982e1dfe: [libomptarget] Refactor DeviceRTL prior to AMDGPU bringup (authored by JonChesterfield). · Explain Why
This revision was automatically updated to reflect the committed changes.
JonChesterfield added a commit: rG7272982e1dfe: [libomptarget] Refactor DeviceRTL prior to AMDGPU bringup.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

PathSize
openmp/
libomptarget/
DeviceRTL/
include/
9 lines
src/
2 lines
2 lines
24 lines
7 lines

Diff 380593

View Options

openmp/libomptarget/DeviceRTL/include/Synchronization.h

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Mapping.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Reduction.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Synchronization.cpp

Loading...
View Options

openmp/libomptarget/DeviceRTL/src/Utils.cpp

Loading...